1903117 - Set up download link when viewing the single-file archive on a non-Mozilla web browser

Status: RESOLVED FIXED

(Firefox :: Profile Backup, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

The "Download { -brand-short-name }" button that's visible when viewing the single-file archive in a non-Mozilla browser doesn't currently do anything. This is because we're still working out how that button is supposed to function.

This bug is for wiring up the right behaviour to that button once we decide what exactly it's supposed to do.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

So my plan is as follows:

1. Have some fallback download URLs for each channel of MOZ_UPDATE_CHANNEL (nightly, aurora, beta, release, esr) in prefs. These will include the UTM parameters for attribution once we get them from lifecycle marketing.
2. Set up a new RemoteSettings collection where we can have the "true", non-fallback links.
3. Query for that collection when rendering the template, and if it finds a URL for the MOZ_UPDATE_CHANNEL, use it - otherwise, use the fallback.

The fallbacks let us create backups even if the RemoteSettings service is down for some reason. The RemoteSettings collection will let us update the download URLs, even for released versions of the client.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1903117 - Make the download link in the single-file archive work. r?#backup-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d272e8ab369
Make the download link in the single-file archive work. r=backup-reviewers,desktop-theme-reviewers,dao,kpatenio

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures @ test_BackupService_resolveArchiveDestFolderPath.js

Backout link: https://treeherder.mozilla.org/jobs?repo=autoland&revision=d52102a5ff2ad47a1efcb5f58281ed1edf6b8ab8

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/backup/tests/xpcshell/test_BackupService_resolveArchiveDestFolderPath.js | test_fallback_to_default - [test_fallback_to_default : 161] Got back the expected folder path

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f35d254c77a2
Make the download link in the single-file archive work. r=backup-reviewers,desktop-theme-reviewers,dao,kpatenio

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f35d254c77a2

Comment 7

[Mike Conley (:mconley) (:⚙️)]

If you've confirmed that it's this patch that caused bug 1906460, feel free to back me out to clear it.

Comment 8

[Serban Stanca [:SerbanS]]

If you are sure that this would be the best option, I will proceed to the backout.

Comment 9

[Serban Stanca [:SerbanS]]

Backed out as requested for causing Bug 1906460.

• Backout link

Comment 10

[Norisz Fay [:noriszfay]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/afe5486d138d

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1233bbda7a5f
Make the download link in the single-file archive work. r=backup-reviewers,desktop-theme-reviewers,dao,kpatenio

Comment 12

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/1233bbda7a5f