1903215 - The account name part of the identity picker can't be clicked on

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Geoff Lankow (:darktrojan)]

• Start a new message.
• Click on the "From" menu list.
• Try to click on one of the grey, italic labels on the right hand side. Nothing happens.
• Click on one of the black labels on the left hand side. Works as intended.

This seems to be happening because the account name label is an addition to the usual elements in a <menuitem>, so clicking on it somehow doesn't get back to the <menulist>. We could put inside the normal label and style to match, that appears to work.

Comment 1

[Martin Giger [:freaktechnik]]

Would pointer-events: none help, so the elements aren't even considered when using a mouse?

Comment 2

[Geoff Lankow (:darktrojan)]

Looks like it. Good idea!

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1903215 - Fix clickability of account label in the identity picker. r=#thunderbird-front-end-reviewers

I also moved these rules into #msgIdentity to prevent unintended consequences (nothing else matches, but you never know).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a5d185b5cbc5
Fix clickability of account label in the identity picker. r=aleca

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9408297 [details]
Bug 1903215 - Fix clickability of account label in the identity picker. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #): no idea
User impact if declined: papercut, clicking on parts of a drop-down list does nothing
Testing completed (on c-c, etc.): on c-c 5 days
Risk to taking this patch (and alternatives if risky): very low

Comment 6

[Corey Bryant]

Comment on attachment 9408297 [details]
Bug 1903215 - Fix clickability of account label in the identity picker. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 128.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/78d630f048b7

Comment 8

[Ramona Gavrilescu]

Confirming this issue as verified fixed for 128.0b4(20240624182435) with macOS 14, Ubuntu 22 and Win10.