1904072 - Disabled menu items show with the same colour as enabled items

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect, P3)

Description

[Brendan Abolivier [:babolivier]]

Attachment: Screenshot from 2024-06-21 16-12-40.png

See the screenshot attached. The "Insert" and "Format" menu items are disabled (since the focus is on the "To" field), but they show with the same colour as enabled items.

I noticed this while testing the latest 128 beta, but I tested 102 and 115 and observed the same issue with 115 (hence setting 115 as the version in this report). In 102, these items appear in a different shade of gray.

I've observed this behaviour in both light and dark mode.

Comment 1

[Alessandro Castellani [:aleca]]

I can't reproduce this on Windows so this might be a Linux only problem.
Richard, can you check this?

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Bug 1904072 - Linux: let disabled menu items look disabled. r=#thunderbird-front-end-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/471756b7ce99
Linux: let disabled menu items look disabled. r=freaktechnik

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 9409070 [details]
Bug 1904072 - Linux: let disabled menu items look disabled. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
User impact if declined: on Linux no visual feedback when menu is disabled
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Corey Bryant]

Comment on attachment 9409070 [details]
Bug 1904072 - Linux: let disabled menu items look disabled. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 128.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/fe9cb8ea958d

Comment 7

[Ramona Gavrilescu]

Confirming this issue as verified fixed for 128.0b5(20240627132026) and 129.0a1(20240701100756) on Linux.