1904190 - Surface Pro X : Since the 127 update, parts of the display is filled with white squares, or with the wrong colours.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[foxenesys]

Attachment: Capture d'écran 2024-06-16 113942.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:127.0) Gecko/20100101 Firefox/127.0

Steps to reproduce:

Updated to 127 version.
Also tried with nigthly 128.

Actual results:

Parts of the dispay are filled with white square.
Some other reports on Reddit : https://www.reddit.com/r/firefox/comments/1df9szu/so_i_guess_the_latest_version_of_firefox_was/

A way to fix it is to disable hardware acceleration.

Comment 1

[foxenesys]

gfx.webrender.software does help, but I suppose it's the same as disabling hardware acceleration.
Video rendering become sluggish (especially during page rendering).

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Graphics' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Mayank Bansal]

Can you type about:support in the address bar of your browser, and copy its contents and attach them on this bug?

Comment 4

[foxenesys]

Attachment: Firefox_about_support.txt

Comment 5

[foxenesys]

(In reply to Mayank Bansal from comment #3)

Can you type about:support in the address bar of your browser, and copy its contents and attach them on this bug?

Yes, of course. File Added.

Comment 6

[Mayank Bansal]

Was Firefox working as expected in V126 (or earlier)?

If yes, could you please use https://mozilla.github.io/mozregression/ (use the Windows gui version), and perform a bisection to find which change caused this issue for you?
The mozregression tool is quite user friendly, manages all the downloads/installation/uninstallation/cleanup automatically. The "good" version would be V126 (or whichever version was working well for you) and the "bad" version would be V127.

Comment 7

[Timothy Nikkel (:tnikkel)]

It seems we might have a problem with Adreno on Windows, bug 1903048 seems to have collected some similar bugs.

Comment 8

[foxenesys]

I didn't know about mozregression. Sounds interesting.
Unfortunately, I ran into antother issue with it, as it crash while starting:

platform: Windows-10-10.0.22631-SP0
python: 3.10.11 FROZEN (64bit)
mozregression: 6.2.2
message: UnicodeEncodeError: 'ascii' codec can't encode character '\xe7' in position 23: ordinal not in range(128)
traceback: File "mozregression-gui.py", line 6, in <module>
File "mozregui\main.py", line 35, in main
File "mozregui\global_prefs.py", line 66, in set_default_prefs
File "mozregui\global_prefs.py", line 57, in save_prefs
File "configobj_init_.py", line 2117, in write

Comment 9

[foxenesys]

(In reply to Timothy Nikkel (:tnikkel) from comment #7)

It seems we might have a problem with Adreno on Windows, bug 1903048 seems to have collected some similar bugs.

True.
This looks quite similair to this issue:
https://bugzilla.mozilla.org/show_bug.cgi?id=1852440

But I tried the force-corner, and it wouldn't help.

Comment 10

[Mayank Bansal]

If you have the time and patience, may i suggest re-installing mozregression with admin privilege, and then running it with admin privileges. Sometimes doing that makes it work.

Comment 11

[Timothy Nikkel (:tnikkel)]

I wonder if the mozregression folks, with this info, would be able to fix the problem in future versions?

Comment 12

[foxenesys]

(In reply to Mayank Bansal from comment #10)

If you have the time and patience, may i suggest re-installing mozregression with admin privilege, and then running it with admin privileges. Sometimes doing that makes it work.

Nope. Still the same.
I'll try later to install python and launch in command line.

Comment 13

[foxenesys]

(In reply to Timothy Nikkel (:tnikkel) from comment #11)

I wonder if the mozregression folks, with this info, would be able to fix the problem in future versions?

mozregression, Python wouldn't build either. I found out my culprit was about my username (Full Name with special characters).
I tested with another Windows profile.

Comment 14

[foxenesys]

Attachment: mozregression.log

I attached the full mozregression log.
I love this tool!

Comment 15

[Mayank Bansal]

Thanks! The last lines of the log says this :

Bug 1888628 - Extract the texture sampling logic out of ps_quad.glsl. r=gw

This simplifies the common infrastructure, removes two varyings from the common set and will allow other patterns to handle sampling differently if they need it (for example an upcoming repeating pattern).

In addition:

• the color parameter is always passed to the fragment shader (it used to be only when no uv_rect was passed).
• v_flags was reorganized a bit so that w is used by the common infrastructure and xyz are available for patterns to use.

Differential Revision: https://phabricator.services.mozilla.com/D206098

So bug 1888628 is the regressor.

Comment 16

[Mayank Bansal]

This bug may be a duplicate of bug 1897444

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1888628

:nical, since you are the author of the regressor, bug 1888628, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 18

[Timothy Nikkel (:tnikkel)]

Thanks. I filed bug 1904276 for the mozregression issue.

Comment 19

[Mayank Bansal]

foxenesys : Could you try the two different builds posted in https://bugzilla.mozilla.org/show_bug.cgi?id=1897444#c12 , and see if your issue is solved by them?

Comment 20

[Mayank Bansal]

never mind. The builds dont fix the issue for other testers.

Comment 21

[Erich Gubler [:ErichDonGubler]]

We suspect this was regressed by a WebRender patch, so tagging as the WebRender component.

Comment 22

[Nicolas Silva [:nical]]

The fix for this is in bug 1897444.

Comment 23

[foxenesys]

(In reply to Nicolas Silva [:nical] from comment #22)

The fix for this is in bug 1897444.

I can confirm 128 nightly is working fine.