1888628 - Extract the texture sampling code out of ps_quad

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Nicolas Silva [:nical]]

It will remove two varyings from the (limited) set that is shared by every shader and simplify the common infrastructure.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1888628 - Extract the texture sampling logic out of ps_quad.glsl. r=gw

This simplifies the common infrastructure, removes two varyings from the common set and will allow other patterns to handle sampling differently if they need it (for example an upcoming repeating pattern.

In addition, v_flags was reorganized a bit so that w is used by the common infrastructure and xyz are available for patterns to use.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19552414c809
Extract the texture sampling logic out of ps_quad.glsl. r=gw

Comment 3

[Sandor Molnar[:smolnar]]

Backed out changeset 19552414c809 (Bug 1888628) for causing wrench bustages as a result of backing out Bug 1889600, Bug 1885571, Bug 1888400, Bug 1887837

Backout link: https://hg.mozilla.org/integration/autoland/rev/4336280a686fe19b35085918e020f2dcdfd7ac51

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | reftests/aa/rounded-rects.yaml == reftests/aa/rounded-rects-ref.png

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b76cb83627a
Extract the texture sampling logic out of ps_quad.glsl. r=gw

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3b76cb83627a

Comment 6

[Mayank Bansal]

Perfherder has detected a talos performance change from push 3b76cb83627af4607b79caf70a03243e6ee6369b.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
16%	rasterflood_gradient	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	915.33 -> 1,058.50
10%	rasterflood_gradient	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	1,216.67 -> 1,333.42
10%	rasterflood_gradient	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	1,212.17 -> 1,327.33
4%	rasterflood_gradient	windows10-64-shippable-qr	e10s fission stylo webrender-sw	1,296.42 -> 1,343.25

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 15

For more information on performance sheriffing please see our FAQ.

(perf sheriffs may have missed on posting the comment here)