1904390 - Flatpak desktop entry uses incorrect window class name (StartupWMClass)

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect)

Description

[[:Chronicle]]

Steps to reproduce:

I pinned Thunderbird to my Linux desktop panel/dock and opened Thunderbird.

Actual results:

Thunderbird launches, and the Thunderbird window shows as a separate duplicate unpinned Thunderbird icon in my Linux desktop panel/dock, instead of the Thunderbird icon that I have pinned to the panel/dock.

Expected results:

With the latest version of the Thunderbird Flatpak (115.12.2), the StartupWMClass of the provided desktop entry has the line "StartupWMClass=thunderbird", whereas the Thunderbird window uses the window class "thunderbird-esr". The desktop entry provided by the Flatpak should be updated to use the line "StartupWMClass=thunderbird-esr".

Comment 1

[Daniel Darnell [:dandarnell]]

Attachment: Bug 1904390 - Fix StartupWMClass for ESR Flatpak builds. r=#thunderbird-build-system-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2e4f7a463d29
Fix StartupWMClass for ESR Flatpak builds. r=rjl

Comment 3

[Daniel Darnell [:dandarnell]]

Comment on attachment 9412139 [details]
Bug 1904390 - Fix StartupWMClass for ESR Flatpak builds. r=#thunderbird-build-system-reviewers

[Approval Request Comment]
User impact if declined: Startup window class on ESR will be incorrect in Flatpak desktop file. I'm requesting beta uplift so the patch can be tested during beta release process before landing on ESR; this patch should have no impact on the beta flatpak, only the desktop file generating script.
Testing completed (on c-c, etc.): Local machine
Risk to taking this patch (and alternatives if risky): Low

Comment 4

[Corey Bryant]

Comment on attachment 9412139 [details]
Bug 1904390 - Fix StartupWMClass for ESR Flatpak builds. r=#thunderbird-build-system-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 129.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/4567c5a70fbb

Comment 6

[Corey Bryant]

Daniel, do we want this in 128?

Comment 7

[Daniel Darnell [:dandarnell]]

Comment on attachment 9412139 [details]
Bug 1904390 - Fix StartupWMClass for ESR Flatpak builds. r=#thunderbird-build-system-reviewers

Yes, this should land on the next ESR release.

[Approval Request Comment]
User impact if declined: Startup window class will be incorrect on ESR Flatpak
Testing completed (on c-c, etc.): Thunderbird Beta
Risk to taking this patch (and alternatives if risky): Low

Comment 8

[Corey Bryant]

Comment on attachment 9412139 [details]
Bug 1904390 - Fix StartupWMClass for ESR Flatpak builds. r=#thunderbird-build-system-reviewers

[Triage Comment]
Approved for esr128

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 128.1.0esr:
https://hg.mozilla.org/releases/comm-esr128/rev/9ef5fea63b55