1905912 - "Grouped by Sort" is not persisted in unified/virtual folders.

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Hartmut Welpmann [:welpy-cw]]

Steps to reproduce:

1. Select the unified inbox.
2. Sort by "Grouped By Sort"
3. Change to another folder.
4. Select unified inbox again.

Expected result:
Unified inbox is grouped by sort after step 4.

Actual result:
Unified inbox is unthreaded after step 4.

As there seems to be no feasible workaround to persist "Grouped By Sort" for these kind of folders, setting severity to S2.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1905912 - Fix persisting of "Grouped By Sort" in virtual folders. r=darktrojan

This basically restores and fixes some supposedly nonsensical and buggy code that had an effect after all.

Comment 2

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1905912 - Test persistance of "Grouped by Sort" in virtual folders. r=darktrojan

Depends on D215499

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c5cada45c8a8
Fix persisting of "Grouped By Sort" in virtual folders. r=darktrojan
https://hg.mozilla.org/comm-central/rev/4bbbc2101acb
Test persistance of "Grouped by Sort" in virtual folders. r=aleca

Comment 4

[Wayne Mery (:wsmwk)]

Thank you for adding the test!

Comment 5

[Alessandro Castellani [:aleca]]

I suspect this patch busted this test: https://treeherder.mozilla.org/logviewer?job_id=468703600&repo=comm-central&lineNumber=2206

Comment 6

[Yury]

You have comm/mail/test/browser/folder-display/browser_watchIgnoreThread.js and comm/mail/base/test/browser/browser_threads.js broken since this push on 25/07/2024:
https://treeherder.mozilla.org/jobs?repo=comm-central&revision=0356f1bb7efd2f4d67fe4bdeaa2117f2768a5c6b

Comment 7

[Wayne Mery (:wsmwk)]

(In reply to Yury from comment #6)

You have comm/mail/test/browser/folder-display/browser_watchIgnoreThread.js and comm/mail/base/test/browser/browser_threads.js broken since this push on 25/07/2024:
https://treeherder.mozilla.org/jobs?repo=comm-central&revision=0356f1bb7efd2f4d67fe4bdeaa2117f2768a5c6b

Comment 8

[Hartmut Welpmann [:welpy-cw]]

(In reply to Wayne Mery (:wsmwk) from comment #7)

(In reply to Yury from comment #6)

You have comm/mail/test/browser/folder-display/browser_watchIgnoreThread.js and comm/mail/base/test/browser/browser_threads.js broken since this push on 25/07/2024:
https://treeherder.mozilla.org/jobs?repo=comm-central&revision=0356f1bb7efd2f4d67fe4bdeaa2117f2768a5c6b

Those have been fixed in bug 1911219.

Comment 9

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9410821 [details]
Bug 1905912 - Fix persisting of "Grouped By Sort" in virtual folders. r=darktrojan

[Approval Request Comment]
Regression caused by (bug #): bug 1895097
User impact if declined: User can't permanently set unified folder to Grouped By Sort. Unified folder already set to Grouped By Sort are stuck that way.
Testing completed (on c-c, etc.): c-c and beta
Risk to taking this patch (and alternatives if risky): Fairly low.

Comment 10

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9410822 [details]
Bug 1905912 - Test persistance of "Grouped by Sort" in virtual folders. r=darktrojan

[Approval Request Comment]
Testing completed (on c-c, etc.): c-c and beta

Should this test fail for the Win32 Debug comm-esr128 build as well, there is bug 1911891 to mitigate that issue.

Comment 11

[Corey Bryant]

Comment on attachment 9410821 [details]
Bug 1905912 - Fix persisting of "Grouped By Sort" in virtual folders. r=darktrojan

[Triage Comment]
Approved for esr128

Comment 12

[Corey Bryant]

Comment on attachment 9410822 [details]
Bug 1905912 - Test persistance of "Grouped by Sort" in virtual folders. r=darktrojan

[Triage Comment]
Approved for esr128
This uplift includes 2 patches

Comment 13

[Daniel Darnell [:dandarnell]]

Thunderbird 128.2.1esr:
https://hg.mozilla.org/releases/comm-esr128/rev/889a7b027962
https://hg.mozilla.org/releases/comm-esr128/rev/b825be1ec638