190611 - Query page crashes if any product has no versions defined

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Dave Miller [:justdave]]

Can't use an undefined value as an ARRAY reference at
/var/www/html/bugzilla-tip/query.cgi line 250.
[Sat Jan 25 09:39:22 2003] [error] [client 64.236.139.249] Premature end of
script headers: /var/www/html/bugzilla-tip/query.cgi

To reproduce:
1. Go to landfill
2. editproducts
3. pick "Another Product"
4. click on "versions"
5. click "delete" by the only version and confirm it.
6. Go to the query page.

Calling this a regression because we had a couple products with no versions in
them on our test install for some reason, and this didn't crash until this
morning's cvs update.

Comment 1

[Jason Pyeron]

from cvs tip, this problem does not occur on our machine, but other problems 
occur when filing new bug... see bug 223570 

that is works for me...

Comment 2

[Vlad Dascalu]

>> that is works for me...

This still exists and it's reproductible on the CVS tip for me.

The crash error message is:

Software error:

Can't use an undefined value as an ARRAY reference at
[www_bugzilla_path]/query.cgi line 257.

Adding a version back to the product makes query.cgi functionable again.

Comment 3

[Vlad Dascalu]

Attachment: Patch

This solves the problem for me and makes this bug fixed for the soon-to-come
2.17.5.

Comment 4

[Vlad Dascalu]

Attachment: Patch 2 (identical but without some redundant leading spaces)

Comment 5

[Vlad Dascalu]

Attachment: Patch with comment

Comment 6

[Vlad Dascalu]

Attachment: Space-identation issue fixed

Comment 7

[Christian Reis]

Comment on attachment 134530 [details] [diff] [review]
Space-identation issue fixed

I've invested a good 30 minutes trying to understand why we don't need to check
for $::versions. This bug only presents itself when the product has no
components *and* no versions; if you have one of the other, the page loads
fine. We should really get to the bottom of this.

This patch *does* fix the symptom of this bug, and I can't see any bad
sideeffects, but it's a bandaid. I'll r= this, but keep it open till we
diagnose the real issue (which will be attached, say, tomorrow?)

Comment 8

[Dave Miller [:justdave]]

a= on the bandaid, in the interest of having in in the release tonight.  Shall
we file a new bug to figure out the real problem? (I hate having bugs with stuff
checked in on them staying open)

Comment 9

[Vlad Dascalu]

Sure. New bug filled: bug 224317: Clean-up band-aid for bug 190611: Query page
crashes if any product has no versions defined.

I copied the CC list from this bug to the 224317 bug.

Comment 10

[Vlad Dascalu]

Checking in query.cgi;
/cvsroot/mozilla/webtools/bugzilla/query.cgi,v  <--  query.cgi
new revision: 1.122; previous revision: 1.121
done