Query page crashes if any product has no versions defined

RESOLVED FIXED in Bugzilla 2.18

Status

()

Bugzilla
Query/Bug List
RESOLVED FIXED
16 years ago
6 years ago

People

(Reporter: justdave, Assigned: Vlad Dascalu)

Tracking

({regression})

2.17.4
Bugzilla 2.18
regression
Bug Flags:
approval +

Details

Attachments

(1 attachment, 3 obsolete attachments)

Can't use an undefined value as an ARRAY reference at
/var/www/html/bugzilla-tip/query.cgi line 250.
[Sat Jan 25 09:39:22 2003] [error] [client 64.236.139.249] Premature end of
script headers: /var/www/html/bugzilla-tip/query.cgi

To reproduce:
1. Go to landfill
2. editproducts
3. pick "Another Product"
4. click on "versions"
5. click "delete" by the only version and confirm it.
6. Go to the query page.

Calling this a regression because we had a couple products with no versions in
them on our test install for some reason, and this didn't crash until this
morning's cvs update.
Target Milestone: --- → Bugzilla 2.18
Blocks: 212878

Comment 1

15 years ago
from cvs tip, this problem does not occur on our machine, but other problems 
occur when filing new bug... see bug 223570 

that is works for me...
(Assignee)

Comment 2

15 years ago
>> that is works for me...

This still exists and it's reproductible on the CVS tip for me.

The crash error message is:

Software error:

Can't use an undefined value as an ARRAY reference at
[www_bugzilla_path]/query.cgi line 257.

Adding a version back to the product makes query.cgi functionable again.
Version: 2.17.3 → 2.17.4
(Assignee)

Comment 3

15 years ago
Created attachment 134524 [details] [diff] [review]
Patch

This solves the problem for me and makes this bug fixed for the soon-to-come
2.17.5.
(Assignee)

Updated

15 years ago
Attachment #134524 - Flags: review?(kiko)
(Assignee)

Comment 4

15 years ago
Created attachment 134526 [details] [diff] [review]
Patch 2 (identical but without some redundant leading spaces)
Attachment #134524 - Attachment is obsolete: true
(Assignee)

Updated

15 years ago
Attachment #134524 - Flags: review?(kiko)
(Assignee)

Comment 5

15 years ago
Created attachment 134529 [details] [diff] [review]
Patch with comment
Attachment #134526 - Attachment is obsolete: true
(Assignee)

Updated

15 years ago
Attachment #134529 - Flags: review?(kiko)
(Assignee)

Comment 6

15 years ago
Created attachment 134530 [details] [diff] [review]
Space-identation issue fixed
Attachment #134529 - Attachment is obsolete: true
(Assignee)

Updated

15 years ago
Attachment #134530 - Flags: review?(kiko)
(Assignee)

Updated

15 years ago
Attachment #134529 - Flags: review?(kiko)

Comment 7

15 years ago
Comment on attachment 134530 [details] [diff] [review]
Space-identation issue fixed

I've invested a good 30 minutes trying to understand why we don't need to check
for $::versions. This bug only presents itself when the product has no
components *and* no versions; if you have one of the other, the page loads
fine. We should really get to the bottom of this.

This patch *does* fix the symptom of this bug, and I can't see any bad
sideeffects, but it's a bandaid. I'll r= this, but keep it open till we
diagnose the real issue (which will be attached, say, tomorrow?)
Attachment #134530 - Flags: review?(kiko) → review+

Updated

15 years ago
Flags: approval?
a= on the bandaid, in the interest of having in in the release tonight.  Shall
we file a new bug to figure out the real problem? (I hate having bugs with stuff
checked in on them staying open)
Flags: approval? → approval+
(Assignee)

Comment 9

15 years ago
Sure. New bug filled: bug 224317: Clean-up band-aid for bug 190611: Query page
crashes if any product has no versions defined.

I copied the CC list from this bug to the 224317 bug.
Assignee: endico → jocuri
(Assignee)

Comment 10

15 years ago
Checking in query.cgi;
/cvsroot/mozilla/webtools/bugzilla/query.cgi,v  <--  query.cgi
new revision: 1.122; previous revision: 1.121
done
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.