1906387 - Rework the drag and drop implementation of calendar and remove invokeEventDragSession

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Alessandro Castellani [:aleca]]

With the changes done in bug 1893119, the very very old drag and drop implementation done for calendar events is not compatible anymore.
https://searchfox.org/comm-central/rev/56d995b6c3afdf9b3167640b2a7abaa0cea15f69/calendar/base/content/calendar-dnd-listener.js#871

We should rework the whole thing and use the current HTML5 DnD API like with do everywhere else in the application.
Also we're temporarily disabling browser_dragEventItem.js and we should re-enable that test once this is done.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1906387 - Fix drag and drop of calendar view items. r=#thunderbird-front-end-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b3bd2792aa9f
Fix drag and drop of calendar view items. r=aleca

Comment 3

[Martin Giger [:freaktechnik]]

Upstream bug got uplifted, now this needs to go too.

Comment 4

[Alessandro Castellani [:aleca]]

Comment on attachment 9411334 [details]
Bug 1906387 - Fix drag and drop of calendar view items. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: Can't drag and drop calendar events
Testing completed (on c-c, etc.): on c-c and beta
Risk to taking this patch (and alternatives if risky): it should be low since this is primarily an API change. We need this on ESR because the m-c patches that triggered the need for these changes got uplifted to ESR.

Comment 5

[Corey Bryant]

Comment on attachment 9411334 [details]
Bug 1906387 - Fix drag and drop of calendar view items. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for esr128

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 128.3.2esr:
https://hg.mozilla.org/releases/comm-esr128/rev/12015e5b9ed1