Closed Bug 1906378 Opened 4 months ago Closed 4 months ago

Port bug 1893119: Separate nsIDragSession objects from nsIDragService

Categories

(Thunderbird :: Upstream Synchronization, defect)

Thunderbird 129
defect

Tracking

(thunderbird_esr128 fixed, thunderbird129 fixed)

RESOLVED FIXED
129 Branch
Tracking Status
thunderbird_esr128 --- fixed
thunderbird129 --- fixed

People

(Reporter: aleca, Assigned: aleca)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

This change nuked all of our drag and drop tests

Assignee: nobody → alessandro
Status: NEW → ASSIGNED
Summary: Port 1893119: Separate nsIDragSession objects from nsIDragService → Port bug 1893119: Separate nsIDragSession objects from nsIDragService
Duplicate of this bug: 1906375
Blocks: 1906387

Pushed by alessandro@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/39057243c11a
Port bug 1893119: Separate nsIDragSession objects from nsIDragService. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch

Comment on attachment 9411328 [details]
Bug 1906378 - Port bug 1893119: Separate nsIDragSession objects from nsIDragService. r=#thunderbird-reviewers

### ESR Uplift Approval Request
* If this is not a sec:{high,crit} bug, please state case for ESR consideration: Massive spate of drag-and-drop test failures on ESR
* User impact if declined: Possible legitimate failures can slip thru with those tests failing
~* Fix Landed on Version: ~
* Risk to taking this patch: Low
* Why is the change risky/not risky? (and alternatives if risky): This should only impact tests

I requested uplift with the wrong flag. Please disregard this comment.

Attachment #9411328 - Flags: approval-mozilla-esr128?

(In reply to Alessandro Castellani [:aleca] from comment #0)

This change nuked all of our drag and drop tests

It's officially nuked all the drag-and-drop tests on comm-esr128 :)

Comment on attachment 9411328 [details]
Bug 1906378 - Port bug 1893119: Separate nsIDragSession objects from nsIDragService. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): 1893119
User impact if declined: Possible legitimate failures can slip thru with those tests failing
Testing completed (on c-c, etc.): Been on c-c for three months
Risk to taking this patch (and alternatives if risky): Low

Attachment #9411328 - Flags: approval-mozilla-esr128? → approval-comm-esr128?

Comment on attachment 9411328 [details]
Bug 1906378 - Port bug 1893119: Separate nsIDragSession objects from nsIDragService. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128

Attachment #9411328 - Flags: approval-comm-esr128? → approval-comm-esr128+
Regressions: 1922944
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: