1922944 - Cannot drag events to different days after update to 128.3.0

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect, P1)

Description

[Iacopo Benesperi [:iacchi]]

This bug was found by a user in the Italian support forum on Windows 10 and confirmed by me on Linux. After updating from 128.2.3 to 128.3.0 there is a feature regression concerning dragging events from one day to another. Up to 128.2.3 it was possible to click on an event on the calendar view and drag it to a different date (e.g. in the month view). After the update to 128.3.0 this is not possible any more and the only way to do so now is to right click to cut the event, paste it in the new day and select to which calendar to assign it to.

Comment 1

[[:thunderbird64bit]]

I confirm this bug!

Comment 4

[Magnus Melin [:mkmelin]]

Not sure why I didn't see it at first. At least in month view, I do get 'cal.dragService.invokeDragSession is not a function'

Comment 5

[Magnus Melin [:mkmelin]]

I don't see the issue on daily.
https://hg.mozilla.org/releases/comm-esr128/pushloghtml?fromchange=THUNDERBIRD_128_2_3esr_RELEASE&tochange=THUNDERBIRD_128_3_0esr_RELEASE - no idea how any of that could have caused it.

Comment 6

[Magnus Melin [:mkmelin]]

I must be blind! Bug 1906378 of course.

Comment 9

[wst]

Drag&Drop of calendar events doesn't work in Multiweek and Month view. There is an error in Browser Toolbox Console at the first attempt to drag&drop:

Uncaught TypeError: cal.dragService.invokeDragSession is not a function
    invokeEventDragSession chrome://calendar/content/calendar-dnd-listener.js:916
    MozCalendarEditableItem chrome://calendar/content/calendar-editable-item.js:122
3 calendar-dnd-listener.js:916:21

Comment 10

[Normz]

I have the same problem using thunderbird new update 128.3.0 esr-3.
I reverted back to the previous version thunderbird which is 128.2.3 esr-2
with this version it works again as a (hopefully temporary) workaround.

link to download the previous version 128.2
https://archive.mozilla.org/pub/thunderbird/releases/128.2.2esr/win64/en-US/

Make sure you disable Auto update after reverting
disconnect from the internet then disable the auto update by following:

You need to be aware that you might have an Updater Program running on your computer. It could even be a part of your Anti-Virus product. So if you have updater software then you need to make Thunderbird exempt.

You could also do the following:

Exit Thunderbird.

Type 'Run' in search and select 'Run' app
In 'Run' app type regedit and click on Ok
Locate HKEY_LOCAL_MACHINE\Software\Policies
Right click on 'Policies' - select 'New ' > 'Key' - name it 'Mozilla'
so you have : HKEY_LOCAL_MACHINE\Software\Policies\Mozilla
right click on 'Mozilla' - select 'New ' > 'Key' - name it 'Thunderbird'
Now you have: HKEY_LOCAL_MACHINE\Software\Policies\Mozilla\Thunderbird
Right click on 'Thunderbird' select 'New' > 'DWORD 32 bit'
On the right, will appear 'new Value' -REG_DWORD - right click on 'new value' and select 'Rename' and rename as 'DisableAppUpdate'.
Note: Even if you are running 64-bit Windows you must still create a 32-bit DWORD value.

Double click on 'DisableAppUpdate' and Set its value to 1. Then click on OK.
Start Thunderbird

Menu icon > Options > Options > Advanced > 'Updates' tab Thunderbird updates It will state current version number. Options are removed and replaced by: 'Updates disabled by your system administrator'

To undo the change, remove the DisableAppUpdate 32-bit DWORD value you have created, then restart Thunderbird.

Comment 11

[rž]

(In reply to Iacopo Benesperi [:iacchi] from comment #0)

Same bug for me on Mac Sonoma 14.0, with the latest Thunderbird (128.3.0esr (64-bit))

Comment 12

[Chris Zim]

Confirming this too. The offending location according to the error console is calendar-dnd-listener.js:916:21 .

Perhaps an overhaul of regression Q/A is in order? :-)

Please let me know if more information is required.

Comment 13

[Wayne Mery (:wsmwk)]

Suggest this is P1.

Comment 15

[Toby Pilling [:tobyp]]

Thanks Wayne. I have asked Martin to take a look and I'll discuss this with Alessandro who authored the regressing patch.

Comment 20

[Magnus Melin [:mkmelin]]

I'm don't understand what happened here. Maybe there was some m-c uplift missing for 128.3.0.

I'm testing 128.3.0 and see the bug. But with 128.3.2esr (the current tip) it's working. Something in between must have fixed it.
Can someone confirm it's working on 128.3.2esr?

Comment 21

[wst]

On version 128.3.1esr the problem was still present. After updating to version 128.3.2esr, drag&drop events seem to work.

Comment 22

[Magnus Melin [:mkmelin]]

Thanks! Let's close this then.

Comment 23

[Magnus Melin [:mkmelin]]

I got an email from someone saying it's working in general, but dragging all-day events in week view is still broken.
I can confirm dragging all-day-events in week-view does not work on daily either - but used to work in earlier 128 (tested 128.2.1esr)

Comment 24

[Magnus Melin [:mkmelin]]

https://searchfox.org/comm-central/rev/806fe422be549c62baa4db1dfb8868e0de48766f/calendar/base/content/calendar-editable-item.js#117-118 has a comment about "day/week view items". This is where we end up (not dragging) when trying to drag all-day items.

Geoff, you added this in bug 1906387. I guess the remaining issue here is a continuation of that.

Comment 25

[Chris Zim]

Confirming that this issue has been resolved for both events tied to a specific time and ally-day event in 128.3.2esr running on Sequoia.

Comment 26

[Ramona Gavrilescu]

Hello,

Tested this issue on Win 10 and Mac Sonoma 14,

1. On the first issue reported, drag&drop Events, it seems that the affected ESR are :
   - 128.3.0 (20240930164946) and
   - 128.3.1 (20241009142959)

     On the other ESR that I tested drag& drop Events works as expected(:week/multiweek/month):      
                     - 128.2.3 (20240919232745) and 
                     - 128.3.2 (20241015205511)
   

2. On the second issue, drag&drop All Day Events it seems that the affected ESR are:
   - 128.3.0 (20240930164946)
   - 128.3.1 (20241009142959) and
   - 128.3.2(20241015205511)

    On the other ESR that I tested, drag&drop All Day Events  works as expected on:
                  - 128.2.1(20240911233837)
                  - 128.2.2( 20240917161604)
                   - 128.2.3 (20240919232745
   

Comment 27

[Francesco]

(In reply to Magnus Melin [:mkmelin] from comment #20)

I'm testing 128.3.0 and see the bug. But with 128.3.2esr (the current tip) it's working. Something in between must have fixed it.

The backport of bug 1893119 to FF 128.3.0 and bug 1906387 to TB 128.3.2 must have fixed everything except all-day items which are now explicitly excluded. So TB 128.3.0 and 128.3.1 didn't work, and from 128.3.2, all-day drags don't work. Anything 128.2.x worked.

I suggest closing this bug with all its confusion and opening a new one for all-day events.

Comment 28

[Nidal]

Please dont forger to test the related Bug 1923170, regarding grad and drop in multi-week and month views

Comment 29

[Geoff Lankow (:darktrojan)]

(In reply to Magnus Melin [:mkmelin] from comment #24)

https://searchfox.org/comm-central/rev/806fe422be549c62baa4db1dfb8868e0de48766f/calendar/base/content/calendar-editable-item.js#117-118 has a comment about "day/week view items". This is where we end up (not dragging) when trying to drag all-day items.

Geoff, you added this in bug 1906387. I guess the remaining issue here is a continuation of that.

That's exactly the problem. Looks like all-day items should have the draggable attribute but they don't.

Comment 30

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1922944 - Make all-day events draggable in the week view. r=#thunderbird-reviewers

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/273999868d3b
Make all-day events draggable in the week view. r=mkmelin

Comment 32

[Geoff Lankow (:darktrojan)]

Comment on attachment 9432765 [details]
Bug 1922944 - Make all-day events draggable in the week view. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1906378
User impact if declined: unable to drag all-day events from one day to another in week view, minor but annoying
Testing completed (on c-c, etc.): in 133.0b1
Risk to taking this patch (and alternatives if risky): low