Folder highlight not visible when dragging messages
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(thunderbird_esr128+ fixed, thunderbird129 fixed)
People
(Reporter: inattee, Assigned: Paenglab)
References
(Blocks 1 open bug)
Details
(Keywords: regression, regressionwindow-wanted)
Attachments
(2 files)
42.50 KB,
image/png
|
Details | |
48 bytes,
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta+
corey
:
approval-comm-esr128+
|
Details | Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:127.0) Gecko/20100101 Firefox/127.0
Steps to reproduce:
Drag and dropped a message from inbox to another folder in the folder pane list.
Actual results:
While dragging the message, the folder list becomes obscured by the outline of the message and it's hard to see which destination folder is being selected.
Expected results:
The destination folders should be highlighted on hover more prominently so they are seen more easily.
Comment 1•2 months ago
|
||
We think this is a regression.
Perhaps Mac only.
Assignee | ||
Comment 2•2 months ago
|
||
Updated•2 months ago
|
Comment 3•2 months ago
|
||
Hello,
This issue was reproduced on Windows 11, macOS 14 and Ubuntu 22.
We have managed to find a regression range for this issue. The mozregression bisection information is as follows:
This is the pushlog_url generated.
2024-07-09T16:26:20.229000: DEBUG : Starting merge handling...
2024-07-09T16:26:20.229000: DEBUG : Using url: https://hg.mozilla.org/comm-central/json-pushes?changeset=02bcc648119abfb8ccacb9f7e3e306ee0c56a4fb&full=1
2024-07-09T16:26:20.230000: DEBUG : redo: attempt 1/3
2024-07-09T16:26:20.230000: DEBUG : redo: retry: calling _default_get with args: ('https://hg.mozilla.org/comm-central/json-pushes?changeset=02bcc648119abfb8ccacb9f7e3e306ee0c56a4fb&full=1',), kwargs: {}, attempt #1
2024-07-09T16:26:20.393000: DEBUG : urllib3.connectionpool: Resetting dropped connection: hg.mozilla.org
2024-07-09T16:26:21.186000: DEBUG : urllib3.connectionpool: https://hg.mozilla.org:443 "GET /comm-central/json-pushes?changeset=02bcc648119abfb8ccacb9f7e3e306ee0c56a4fb&full=1 HTTP/1.1" 200 None
2024-07-09T16:26:21.232000: DEBUG : Found commit message:
Bug 1899842 - Add a selection indicator pill in folder pane and address book pane. r=aleca
Differential Revision: https://phabricator.services.mozilla.com/D212147
2024-07-09T16:26:21.232000: DEBUG : Did not find a branch, checking all integration branches
2024-07-09T16:26:21.234000: INFO : The bisection is done.
2024-07-09T16:26:21.235000: INFO : Stopped```
Comment 4•2 months ago
|
||
Thanks Richard for tackling this, I'll review it asap
Assignee | ||
Updated•2 months ago
|
Pushed by daniel@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/f1fde1b7e2df
Use the "focused/current" background color for the folder pane drop target. r=vineet
Comment 6•2 months ago
|
||
Comment on attachment 9411680 [details]
Bug 1906758 - Use the "focused/current" background color for the folder pane drop target. r=#thunderbird-front-end-reviewers
[Triage Comment]
Approved for beta to get this quickly to 128
Comment 7•2 months ago
|
||
bugherder uplift |
Thunderbird 129.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/45268cccf545
Comment 8•1 month ago
|
||
Richard, we'd like to pick this up in 128.1.0esr. Please let us know what you think, and if you agree, can you add the the uplift request details?
Assignee | ||
Comment 9•1 month ago
|
||
Comment on attachment 9411680 [details]
Bug 1906758 - Use the "focused/current" background color for the folder pane drop target. r=#thunderbird-front-end-reviewers
[Approval Request Comment]
User impact if declined: Almost invisible drop target highlight in folder pane
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Comment 10•1 month ago
|
||
Comment on attachment 9411680 [details]
Bug 1906758 - Use the "focused/current" background color for the folder pane drop target. r=#thunderbird-front-end-reviewers
Thanks Richard!
[Triage Comment]
Approved for esr128
Comment 11•1 month ago
|
||
bugherder uplift |
Thunderbird 128.1.0esr:
https://hg.mozilla.org/releases/comm-esr128/rev/15bfecbc3b24
Updated•1 month ago
|
Description
•