1906888 - Update focus order for vertical tabs and new tab button

Status: RESOLVED FIXED

(Firefox :: Sidebar, task, P1)

Description

[Sarah Clements [:sclements]]

We need to update the focus order and HCM work for the vertical tabs, pinned tabs and new tab button in the sidebar per the spec, but it depends on the work done in bug 1899336.

Comment 1

[Anna Yeddi [:ayeddi]]

hi team, when it's ready for testing could you please add flag a11y-review=requested? I'll be on PTO for the next couple of weeks and want to make sure my team would get notified and could take on the review even when I'm away.

Comment 2

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1906888 - Update focus order and move new tab button to the bottom for vertical tabs r=#tabbrowser-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb2f7f9f6def
Update focus order and move new tab button to the bottom for vertical tabs r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sidebar-reviewers,ayeddi

Comment 4

[Atila Butkovits]

Backed out for causing failures at browser_newtabButton.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/d795bab98182af020767cb2e0486208cf5cf34eb

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=fR1a8_TtQN6Hz37TDZ9-rw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=fb2f7f9f6defaae96826e293b2bc5924372dddf2

Failure log: https://treeherder.mozilla.org/logviewer?job_id=475028366&repo=autoland&lineNumber=3790

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9631f22a70c9
Update focus order and move new tab button to the bottom for vertical tabs r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sidebar-reviewers,ayeddi

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9631f22a70c9