1907127 - Add a new update state to delay installations

Status: RESOLVED FIXED

(Toolkit :: Application Update, task, P3)

Comment 1

[Max Christian Pohle [:/dev/max]]

Attachment: WIP: Bug 1907127 - Delay updates with multiple instances, r=bytesized

Comment 3

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1907127 - Adds `usingDefaultInstallDate` to `Update` objects r=nrishel!,nalexander!

In this patch stack, we will want to be able to know if the install date stored in the update object is actually a legitamate value or just its default initialization value so this changeset adds a member to keep track of that.

Note that this does not add usingDefaultInstallDate to the nsIUpdate interface.

Comment 4

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1907127 - Add support for writing update.timestamp r=nrishel!,nalexander!

Comment 5

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1907127 - Read update.timestamp at startup and use it to delay updates r=nrishel!,nalexander!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb625b7eb786
Adds `usingDefaultInstallDate` to `Update` objects r=nrishel,nalexander,application-update-reviewers
https://hg.mozilla.org/integration/autoland/rev/b9604bb0b576
Add support for writing update.timestamp r=nrishel,nalexander,application-update-reviewers
https://hg.mozilla.org/integration/autoland/rev/77099a71e959
Read update.timestamp at startup and use it to delay updates r=nrishel,nalexander,application-update-reviewers

Comment 7

[Cristina Horotan [:chorotan]]

Backed out for causing build bustages

Backout link

Push with failures

Failure log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/608d68ca5b0e
Adds `usingDefaultInstallDate` to `Update` objects r=nrishel,nalexander,application-update-reviewers
https://hg.mozilla.org/integration/autoland/rev/8f6065837da3
Add support for writing update.timestamp r=nrishel,nalexander,application-update-reviewers
https://hg.mozilla.org/integration/autoland/rev/118a3fe99c1e
Read update.timestamp at startup and use it to delay updates r=nrishel,nalexander,application-update-reviewers

Comment 9

[amarc]

https://hg.mozilla.org/mozilla-central/rev/608d68ca5b0e
https://hg.mozilla.org/mozilla-central/rev/8f6065837da3
https://hg.mozilla.org/mozilla-central/rev/118a3fe99c1e

Comment 11

[Robin Steuber (she/her) [:bytesized]]

Attachment: Backed out changeset a4acaa6581bb (Bug 1907127 - Make common test functionality more self contained) r=nrishel!

Comment 12

[Robin Steuber (she/her) [:bytesized]]

Attachment: Backed out changeset 0743d5998d6a (Bug 1907127 - Add testing for the multi session install lock feature) r=nrishel!

Comment 13

[Robin Steuber (she/her) [:bytesized]]

Attachment: Backed out changeset 811fa9d7c8a6 (Bug 1907127 - Add telemetry to monitor reasons why we don't apply updates at startup) r=nrishel!

Note, this wasn't a perfectly clean backout because I am not backing out Bug 1938657, but I am very confident in it because the necessary merge was simply to remove the added lines from shared_metrics.yaml instead of metrics.yaml.

Comment 14

[Robin Steuber (she/her) [:bytesized]]

Attachment: Backed out changeset 2a19a01424f1 (Bug 1907127 - Remove other multi-instance checks now that we check at startup) r=nrishel!

Comment 15

[Phabricator Automation]

Comment on attachment 9480367 [details]
Backed out changeset a4acaa6581bb (Bug 1907127 - Make common test functionality more self contained) r=nrishel!

Revision D246291 was moved to bug 1960981. Setting attachment 9480367 [details] to obsolete.

Comment 16

[Phabricator Automation]

Comment on attachment 9480368 [details]
Backed out changeset 0743d5998d6a (Bug 1907127 - Add testing for the multi session install lock feature) r=nrishel!

Revision D246292 was moved to bug 1960981. Setting attachment 9480368 [details] to obsolete.

Comment 17

[Phabricator Automation]

Comment on attachment 9480371 [details]
Backed out changeset 811fa9d7c8a6 (Bug 1907127 - Add telemetry to monitor reasons why we don't apply updates at startup) r=nrishel!

Revision D246295 was moved to bug 1960981. Setting attachment 9480371 [details] to obsolete.

Comment 18

[Phabricator Automation]

Comment on attachment 9480372 [details]
Backed out changeset 2a19a01424f1 (Bug 1907127 - Remove other multi-instance checks now that we check at startup) r=nrishel!

Revision D246297 was moved to bug 1960981. Setting attachment 9480372 [details] to obsolete.