1907416 - Feature callouts close when a tab preview thumbnail panel appears

Status: RESOLVED DUPLICATE of bug 1878051

(Firefox :: Messaging System, defect, P1)

Description

[Shane Hughes [:aminomancer]]

Feature Callouts currently close when another panel appears, to avoid having multiple stacked panels. This has become a bit more problematic with the addition of tab preview thumbnails, which use panel elements and appear on merely hovering a tab. If a callout triggers on opening or selecting a tab, the callout will appear when you do that, but rapidly disappear as your mouse is now hovering a tab, resulting in a flash and a "false impression."

I'm not sure what will happen if we add an exclusion to that logic for tab preview thumbnails. Would feature callouts stack above or below them? Would be good to test this, but even if there's some z-fighting, I think it's still better than what we have now.

Also, we want the whole "close when a panel opens" behavior to be configurable, because we plan to run experiments where feature callouts are actually anchored to elements inside other panels, like highlighting a search engine button within the upcoming Unified Search Button menu. For that kind of thing to work well, we may need to provide a property that allows callouts to opt out of this auto-close behavior in the switch statement. So we might as well do that here while we're modifying the switch statement.

This has the potential to create a pretty bad user experience and really mess up experiment results, so I want to suggest P1, S3. Thankfully tab previews are restricted to Nightly for now, but probably not for long.

Comment 1

[Mimi Jung]

Do you have test steps for this Shane? I might be missing something obvious but in about:asrouter I've rendered the following feature callouts:
TEST_FEATURE_TOUR
EXPERIMENT_L10N_TEST

and then hovered over a tab in Nightly for tab preview but the preview doesn't show when the callout is rendered (and it also doesn't cause it to dismiss as a result).

I also tested with the fx view callout: https://experimenter.services.mozilla.com/nimbus/fx-view-discoverability-rollout/summary and it looks like the callout is blocking the tab preview so it's not being closed as a result. But maybe I'm missing a step here!

Comment 2

[Shane Hughes [:aminomancer]]

No special test steps, what you did would have shown an issue if it was still present. Looks like this was fixed at the tab tooltip level in bug 1878051.