1907440 - Fix regression in compose API: Do not report fcc folder instead of throwing, if accountsRead permission is missing

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Comment 1

[John Bieling (:TbSync)]

Attachment: Bug 1907440 - Fix regression in compose API: Do not report fcc folders instead of throwing, if accountsRead permission is missing. r=#thunderbird-reviewers

The folderManager property does not exist in the extension object,
unless the accountsRead permission is granted. We therefore need to
check the permission before using it. This was forgotten in two places
of the Compose API.

Comment 2

[Johannes Buchner]

John Bieling, I'm following up your add-on comment pointing to this bug report. I don't understand what I would have to do. Could you please create a pull request to https://github.com/JohannesBuchner/thunderbird-ai-grammar-mailextension/ ?

Comment 3

[John Bieling (:TbSync)]

(In reply to Johannes Buchner from comment #2)

John Bieling, I'm following up your add-on comment pointing to this bug report. I don't understand what I would have to do. Could you please create a pull request to https://github.com/JohannesBuchner/thunderbird-ai-grammar-mailextension/ ?

Hi Johannes,

this bug prevents your add-on from functioning in Thunderbird 128.

The manifest.json file of your add-on has "strict_max_version": "115.*", which means you manually limited your add-on from being used in Thunderbird 128, so you do not have to do anything at the moment. But at some point you want to release your add-on for Thunderbird 128 of course. You have two options:

1. Wait till this bug is fixed and the patch has made it into Thunderbird 128 (I will report that here)
2. Add the "accountsRead" permission to your manifest and release an updated version now already. Once the bug is fixed, you can remove the permission again.

I filed a PR with the required changes for option #2.

Please note, that you are also affected by Bug 1906833 :-(
(To work around this bug, users have to add the encryption button back to the compose window.)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/93d332433a20
Fix regression in compose API: Do not report fcc folders instead of throwing, if accountsRead permission is missing. r=mkmelin

Comment 5

[John Bieling (:TbSync)]

Comment on attachment 9412360 [details]
Bug 1907440 - Fix regression in compose API: Do not report fcc folders instead of throwing, if accountsRead permission is missing. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): 1732669
User impact if declined: A standard API call causes the compose window to freeze
Testing completed (on c-c, etc.): one day, no negative impacts
Risk to taking this patch (and alternatives if risky): Low

Comment 6

[John Bieling (:TbSync)]

Comment on attachment 9412360 [details]
Bug 1907440 - Fix regression in compose API: Do not report fcc folders instead of throwing, if accountsRead permission is missing. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): 1732669
User impact if declined: A standard API call causes the compose window to freeze
Testing completed (on c-c, etc.): one day, no negative impacts
Risk to taking this patch (and alternatives if risky): Low

Comment 7

[John Bieling (:TbSync)]

Comment on attachment 9412360 [details]
Bug 1907440 - Fix regression in compose API: Do not report fcc folders instead of throwing, if accountsRead permission is missing. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): 1732669
User impact if declined: A standard API call causes the compose window to freeze
Testing completed (on c-c, etc.): one day, no negative impacts
Risk to taking this patch (and alternatives if risky): Low

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9412360 [details]
Bug 1907440 - Fix regression in compose API: Do not report fcc folders instead of throwing, if accountsRead permission is missing. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta
Approved for esr128
APproved for release

Comment 9

[Daniel Darnell [:dandarnell]]

Thunderbird 128.0.1esr:
https://hg.mozilla.org/releases/comm-esr128/rev/997e2afb9c55

Comment 10

[Daniel Darnell [:dandarnell]]

Thunderbird 129.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/d9eba9b74481