1907603 - TypeError: aPart is null MimeMessage.sys.mjs:142:7

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[[:DaAnda]]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0

Steps to reproduce:

this error shows up in the JS console after startup

Actual results:

not sure if it is related, but in the activity window I can see that Thunderbird tries to index the messages of an IMAP mailbox and it seems to be stuck there. As this happens on every startup (TB trying to index + this error) I think they could be related. Also none of the messages of the mailbox are actually indexed (do not show up in global search) - so there certainly is a bug with indexing, but as said, not sure if the indexing bug is related to this error as I am not familiar with TBs codebase.

Full error message in the console:

TypeError: aPart is null MimeMessage.sys.mjs:142:7
    stripEncryptedParts resource:///modules/gloda/MimeMessage.sys.mjs:142
    wrapCallback resource:///modules/gloda/MimeMessage.sys.mjs:216
    _finalize resource:///modules/gloda/MimeMessage.sys.mjs:108
    OnStopRunningUrl resource:///modules/gloda/MimeMessage.sys.mjs:80

Expected results:

the respective method stripEncryptedParts should check of a null value before attempting to process the data, or the check should be done further up the chain before calling this method.

Comment 1

[[:DaAnda]]

forgot to mention the detailed version used since I was not able to select it in the form. I am running 128.0b6 (64-Bit) via flatpak from flathub

Comment 2

[Magnus Melin [:mkmelin]]

Probably from bug 1851074 (but would have to be verified)
https://searchfox.org/comm-central/rev/357f10f63c8f798093aadc02ea9217d791251dbe/mailnews/db/gloda/modules/MimeMessage.sys.mjs#80,108

Comment 3

[[:DaAnda]]

still present in 129.0b4 (64-Bit)

Comment 4

[u758982]

I'm having a similar problem running Thunderbird 128.1.0esr on macOS. Indexing a particular local folder gets stuck and never finishes. When I'm looking at the Error Console, I see that same "aPart is null" error when indexing gets stuck. My guess is, one of the emails in the local folder has something weird that's causing GLODA to choke. I get 3 errors in a row, and the 3rd one is the "TypeError: aPart is null". All three are shown below:

TypeError: RecurIterator._expandMap[this.rule.freq] is undefined
Ical.sys.mjs:5082:24
    setup_defaults resource:///modules/calendar/Ical.sys.mjs:5082
    init resource:///modules/calendar/Ical.sys.mjs:3949
    fromData resource:///modules/calendar/Ical.sys.mjs:3887
    RecurIterator resource:///modules/calendar/Ical.sys.mjs:3761
    iterator resource:///modules/calendar/Ical.sys.mjs:5387
    _expandComponent resource:///modules/calendar/Ical.sys.mjs:2882
    _ensureCoverage resource:///modules/calendar/Ical.sys.mjs:2791
    utcOffset resource:///modules/calendar/Ical.sys.mjs:2682
    convert_time resource:///modules/calendar/Ical.sys.mjs:2458
    convertToZone resource:///modules/calendar/Ical.sys.mjs:1531
    getInTimezone resource:///modules/CalDateTime.sys.mjs:133
    getItemDates resource:///modules/calendar/utils/calDateTimeFormatter.sys.mjs:453
    formatItemInterval resource:///modules/calendar/utils/calDateTimeFormatter.sys.mjs:474
    updateInvitationOverlay resource:///modules/calendar/utils/calInvitationUtils.sys.mjs:432
    setField resource:///modules/calendar/utils/calInvitationUtils.sys.mjs:380
    updateInvitationOverlay resource:///modules/calendar/utils/calInvitationUtils.sys.mjs:418
    createInvitationOverlay resource:///modules/calendar/utils/calInvitationUtils.sys.mjs:292
    convertToHTML resource:///modules/CalMimeConverter.sys.mjs:59

NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "RecurIterator._expandMap[this.rule.freq] is undefined" {file: "resource:///modules/calendar/Ical.sys.mjs" line: 5082}]'[JavaScript Error: "RecurIterator._expandMap[this.rule.freq] is undefined" {file: "resource:///modules/calendar/Ical.sys.mjs" line: 5082}]' when calling method: [calIDateTime::getInTimezone] calDateTimeFormatter.sys.mjs:453
    getItemDates resource:///modules/calendar/utils/calDateTimeFormatter.sys.mjs:453
    formatItemInterval resource:///modules/calendar/utils/calDateTimeFormatter.sys.mjs:474
    updateInvitationOverlay resource:///modules/calendar/utils/calInvitationUtils.sys.mjs:432
    setField resource:///modules/calendar/utils/calInvitationUtils.sys.mjs:380
    updateInvitationOverlay resource:///modules/calendar/utils/calInvitationUtils.sys.mjs:418
    createInvitationOverlay resource:///modules/calendar/utils/calInvitationUtils.sys.mjs:292
    convertToHTML resource:///modules/CalMimeConverter.sys.mjs:59

TypeError: aPart is nullMimeMessage.sys.mjs:142:7
    stripEncryptedParts resource:///modules/gloda/MimeMessage.sys.mjs:142
    wrapCallback resource:///modules/gloda/MimeMessage.sys.mjs:216
    _finalize resource:///modules/gloda/MimeMessage.sys.mjs:108
    OnStopRunningUrl resource:///modules/gloda/MimeMessage.sys.mjs:80

Comment 6

[Magnus Melin [:mkmelin]]

Not sure about the other specifics, but what we can say is,
https://searchfox.org/comm-central/rev/357f10f63c8f798093aadc02ea9217d791251dbe/mailnews/db/gloda/modules/MimeMessage.sys.mjs#80 will pass null ... down to https://searchfox.org/comm-central/rev/357f10f63c8f798093aadc02ea9217d791251dbe/mailnews/db/gloda/modules/MimeMessage.sys.mjs#216 and part ends up null

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: Bug 1907603 - Fix "TypeError: aPart is null MimeMessage.sys.mjs". r=john.bieling

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e8cbb1f0460f
Fix "TypeError: aPart is null MimeMessage.sys.mjs". r=john.bieling

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 9420071 [details]
Bug 1907603 - Fix "TypeError: aPart is null MimeMessage.sys.mjs". r=john.bieling

[Approval Request Comment]
Regression caused by (bug #): bug 1851074
User impact if declined: unclear, but failures on various occasions
Testing completed (on c-c, etc.): c-c, beta
Risk to taking this patch (and alternatives if risky): safe

Comment 10

[Wayne Mery (:wsmwk)]

Thanks for requesting the uplift, because this is a high value issue, due to its impact on search results. And A regression of v120, according to bug 1851074.

Are there no tests behind this?

Comment 11

[Magnus Melin [:mkmelin]]

Not sure. I think the code in general is actually tested. But it's unclear what data would produce this error situation.

Comment 12

[Wayne Mery (:wsmwk)]

Yeah. To be more specific, can we test whether messages that might be affected by this situation do get indexed.

Comment 13

[Magnus Melin [:mkmelin]]

Only if we get a test case for what such a message looks like.

Comment 14

[[:DaAnda]]

I'd like to help but after I have deleted (like emptied trash) and moved some messages into archive folders, I no longer seem to get this error. So whatever message might have caused this seems to be gone on my end and this accounts mailbox is also indexed now.

Comment 15

[Corey Bryant]

Comment on attachment 9420071 [details]
Bug 1907603 - Fix "TypeError: aPart is null MimeMessage.sys.mjs". r=john.bieling

[Triage Comment]
Approved for esr128

Comment 16

[Daniel Darnell [:dandarnell]]

Thunderbird 128.2.1esr:
https://hg.mozilla.org/releases/comm-esr128/rev/18642e64b9de