1907939 - [Toolbar Redesign] PWA displays the navbar/spacing after returning from a link while in Landscape mode

Status: RESOLVED FIXED

(Fenix :: Toolbar, defect)

Description

[Delia Pop]

Attachment: QA.mp4

Steps to reproduce

1. Open latest Nightly with the navigation toolbar enabled by default.
2. Position address bar at bottom..
3. Open a PWA.
4. Navigate a link from PWA.
5. Rotate the device to landscape.
6. Press back.

Expected behavior

The address bar and the navigation toolbar are not displayed on PWAs installed from latest Nightly.

Actual behavior

Similar to 1906784, after returning to PWA from the accessed link (but while in Landscape mode), the navigation bar is displayed (when the address bar is set to bottom), and an empty space is displayed at the top of the screen (when the address bar is set to top).

Device information

• Firefox version: Nightly 130.0a1 from 07/15
• Android device model: Samsung Galaxy S22 Ultra
• Android OS version: Android 14

Any additional information?

The initial issue Mike described in 1906784, could no longer be reproduced if the device is rotated back to portrait mode before tapping the back button. Instead, the back button has to be tapped while in Landscape mode in order to reproduce the issue.
Not reproducible on tablet devices.

Comment 1

[Mike a [:mavduevskiy]]

Attachment: Bug 1907939 - Fix hideToolbarFeature stop working in PWA on device rotation

The use case to catch this one is a bit tricky: we should start in a PWA mode, that hides the toolbar, then navigate a link withing the PWA. The next page would show the toolbar, giving user the ability navigate back. Normally, if the user does navigate back, the hideToolbarFeature would hide the toolbar again.
The problem came from onUpdateToolbarForConfigurationChange, that would be removing the toolbar - the wrapper lifecycle was dependant on the toolbarview, while previously toolbar view was only detached along with the fragment view.

Comment 2

[Mike a [:mavduevskiy]]

Prepare: visit "https://community.wanikani.com" and install it as a PWA via "Add to HomeScreen". The convenient test case borrowed from here

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9505d833ab45
Fix hideToolbarFeature stop working in PWA on device rotation r=android-reviewers,Roger

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/9505d833ab45