1908800 - Make "search-header" behaviour automatic

Status: NEW

(Firefox :: Settings UI, defect, P2)

Description

[:Gijs (he/him)]

Right now when the "find in page" settings UI functionality finds items, it somehow relies on h2 headers with a specific class. I think this is because the h1 headers look too big if shown in the search pane? Regardless, this is:

• resulting in duplicate markup that is annoying to keep up-to-date and to ensure the same text only appears once (which became an issue in the Firefox Labs / Nightly Experiments pane at some point)
• easy to forget - there are probably cases in settings right now where checkboxes appear without the context of their section, and/or where the section header cannot be found using find-in-page.
• a footgun for new code: when the above means that searching for the header does not show the entire section (which was what happened in bug 1907709), it can be misconstrued as an intentional thing, when in fact it's just a bug/quirk in how the find in page code works.

We should come up with a more structural solution to this problem.

Mark, do you think there's anything we can do about this before the settings redesign is in full swing and swaps us to cards, or something? How hard would it be for the find in page code to also check h1 settings (though note also bug 1845411), or to switch over to using h2 more consistently?

Comment 1

[:Gijs (he/him)]

Adding needinfo that was meant to go with comment 0