1907709 - Searching for "Advertising" doesn't find the the "Website Advertising Preferences" section

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Tom S [:evilpie]]

For some reason searching for "Advertising" doesn't find that section. On the other hand searching for "collection" finds the section "Nightly Data Collection and Use". I think this has something to do with the search-header class.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1901068

:emilio, since you are the author of the regressor, bug 1901068, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1907709 - Add a search header for website advertising section. r=#settings-reviewers

A bit weird that this doesn't work more automatically but...

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9412983 [details]
Bug 1907709 - Add a search header for website advertising section. r=#settings-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: New settings section not easily findable.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One-liner to add it to the search text.
• String changes made/needed: none
• Is Android affected?: No

Comment 4

[aoia7rz7l]

(In reply to Tom S [:evilpie] from comment #0)

For some reason searching for "Advertising" doesn't find that section. On the other hand searching for "collection" finds the section "Nightly Data Collection and Use". I think this has something to do with the search-header class.

Most likely related to bug 1390499?

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

Created attachment 9412983 [details]
Bug 1907709 - Add a search header for website advertising section. r=#settings-reviewers

A bit weird that this doesn't work more automatically but...

May I also propose adding ppa as a search keyword (e.g. https://searchfox.org/mozilla-central/rev/543de310042c1cbe98963fc496698522454eb495/browser/components/preferences/privacy.inc.xhtml#1197 or bug 1495612).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09f63cde74c7
Add a search header for website advertising section. r=settings-reviewers,Gijs

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/09f63cde74c7

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9412983 [details]
Bug 1907709 - Add a search header for website advertising section. r=#settings-reviewers

Approved for 129.0b6

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/f1630089cf30

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9412983 [details]
Bug 1907709 - Add a search header for website advertising section. r=#settings-reviewers

Approved for 128.1esr.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/5f66270c17d0

Comment 12

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 129.0b5 on Windows 10x64. Searching Advertising inside the Preferences page will return no results.
The issue is verified fixed with Firefox 130.0a1 (2024-07-30), 129.0b6 from comment 9, and 128.1esr from comment 11 on Windows 10x64, macOS 12, and Ubuntu 23.10.

However, intermittently, on my Windows 10 and macOS 12 stations, I can still see the issue, especially with Nightly (I saw it on macOS 12 with 129.0b6), when I'm searching for the Advertising section. On another two Windows 10 stations, this works as intended so maybe this is intermittent. Please see the screen recording where it works after some time. Should we close this issue and file another one? Thank you!

Comment 13

[:Gijs (he/him)]

(In reply to Alexandru Trif, Desktop QA [:atrif] from comment #12)

However, intermittently, on my Windows 10 and macOS 12 stations, I can still see the issue, especially with Nightly (I saw it on macOS 12 with 129.0b6), when I'm searching for the Advertising section. On another two Windows 10 stations, this works as intended so maybe this is intermittent. Please see the screen recording where it works after some time. Should we close this issue and file another one? Thank you!

You're too quick. :-)

bug 1852120 is on file about this type of issue, and it isn't really related to the specifics here.

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Yeah that doesn't seem related to this specifically.

Comment 15

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Thank you both for the explanation. Changing flags based on the above comments.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9412983 [details]
Bug 1907709 - Add a search header for website advertising section. r=#settings-reviewers

Approved for 128.0.2

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/d664a50d76b8

Comment 18

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 128.0.2 on Windows 10x64, macOS 13 and Ubuntu 23.