1908950 - [toolbar redesign] In custom tab, toolbar-with-navbar now shows two backarrow-buttons (one on each toolbar-level), which do two different things

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot

Steps to reproduce

1. Tap a link from an email, to open Firefox Nightly as an "app tab"
2. Look at the buttons available on your toolbar. Navigate around and try tapping Firefox's back arrow buttons.

Expected behavior

Intuitive buttons, no duplicate-looking/confusing buttons.

Actual behavior

There are two toolbars at the bottom, and both of them have a back-arrow-button at the left side.

• The upper one returns directly to the app (e.g. your email app)
• The lower one is an actual back navigation button.
• They have the exact same icon (left arrow).

Device information

• Firefox version: 130.0a1 2024-07-18
• Android device model: Pixel 8
• Android OS version: 14

Comment 1

[Daniel Holbert [:dholbert]]

(I think this is a new issue as of when the navbar was enabled -- at least, the navbar here is the portion that added the second backarrow button -- hence, flagging as a regression from bug 1902798 to get it properly associated with that work. Feel free to adjust/add other bug relationships if there's a preferred way to track navbar bugs.)

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1902798

:mavduevskiy, since you are the author of the regressor, bug 1902798, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Daniel Holbert [:dholbert]]

(Er, I forgot the terminology - it looks like we call these "custom tabs" rather than "app tabs", per https://bugzilla.mozilla.org/describecomponents.cgi?product=Fenix . Updating summary.)

Comment 4

[Mike a [:mavduevskiy]]

Hi, Daniel. Thanks for reporting the bug.

It might also be fixed by 1904325, as we disabled customization of the close button when the navigation bar is enabled. Hence, it should always be a cross icon for the closing tab action. The patch landed somewhere around filling this bug, and it appears to be fixed in nightly. Could you verify that it's safe to close?

Comment 5

[Daniel Holbert [:dholbert]]

Yup, the close button is now an x for me in Nightly. Thanks! Resolving as fixed-by-bug 1904325, or feel free to adjust resolution as you see fit.