1904325 - [Menu Redesign] Support custom tab configurations for the new navbar

Status: VERIFIED FIXED

(Firefox for Android :: Toolbar, task, P1)

Description

[Petru-Mugurel Lingurar [:petru]]

Attachment: CustomTabWithCurrentAddressBar.mp4

Based on

• https://developer.chrome.com/docs/android/custom-tabs
• https://developer.chrome.com/docs/android/custom-tabs/browser-support
  a browser should support various customizations provided by the starting app.

Currently Fenix support a limited subset [1] with the new navbar getting some for free but other important ones not being supported.
Testing with dev-tabs-launcher [2] I see the following features working/missing:

Feature	Addressbar	Navbar
Colours
- choosing between ligtht/dark/system theme	✅	❌
- choosing toolbar theme	✅	❌
- choosing system navbars theme	✅	✅
- change menu color	❌	❌
- pass colour scheme to Gecko	❌	❌
Custom buttons
- custom close button	✅	✅
- custom action button	✅	✅
- whether to show or not the share button	✅	❌
- custom options in the 3dot menu	✅	❌

[1] https://searchfox.org/mozilla-central/rev/93692d0756f01f99e2b028e40b45776fa0a397e9/mobile/android/android-components/components/feature/customtabs/src/main/java/mozilla/components/feature/customtabs/CustomTabsToolbarFeature.kt#132
[2] https://github.com/ohmae/dev-tabs-launcher

Comment 1

[Petru-Mugurel Lingurar [:petru]]

In regards to the navbar I think we should address asap the features supported by the addressbar and not yet supported by the navbar.

Later we can look into supporting a larger set of custom tab customisations. Having two toolbars (addressbar + navbar) supporting this should allow for an improved user experience.
To note that two toolbars should've already be supported with customized colours [2], buttons [2] and gestures [3].

[1] https://developer.android.com/reference/androidx/browser/customtabs/CustomTabsIntent.Builder#setSecondaryToolbarColor(int)
[2] https://developer.android.com/reference/androidx/browser/customtabs/CustomTabsIntent.Builder#setSecondaryToolbarViews(android.widget.RemoteViews,int[],android.app.PendingIntent)
[3] https://developer.android.com/reference/androidx/browser/customtabs/CustomTabsIntent.Builder#setSecondaryToolbarSwipeUpGesture(android.app.PendingIntent)

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: CustomTabWithNavbar.mp4

Showing missing colours and action buttons customisations when using the new navbar.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1904325 - part 1: Have both the address bar and the navbar set the custom menu in the same way r=#android-reviewers

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: WIP: Bug 1904325 - Avoid always showing the share button in custom tabs menu

Since custom tabs can declare whether they want to have the share menu shown or not
we should stop showing it by default in the 3dot menu.

When custom tabs ask for the option to be shown it will be shown as an action in the
address bar.

This patch reverses the changes from bug 1899394.

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1904325 - Have both the address bar and the navbar set the custom menu in the same way r=#android-reviewers

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1904325 - Show a share button as addressbar action in custom tabs only if they ask for r=#android-reviewers

Since custom tabs can declare whether they want to have the share menu shown or not
we should stop showing it by default in the 3dot menu.

When custom tabs ask for the option to be shown it will be shown as an action in the
address bar.

This patch reverses the changes from bug 1899394.

Comment 7

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1904325 - part 2: Extract color inference methods from CustomTabsToolbarFeature r=#android-reviewers

Allow these to then be used for other similar functionalities, like for how
the navbvar should look like when used for custom tabs.

Comment 8

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1904325 - part 3: Allow custom tabs to configure navbar colors r=#android-reviewers

Comment 9

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1904325 - Extract color inference methods from CustomTabsToolbarFeature r=#android-reviewers

Allow these to then be used for other similar functionalities, like for how
the navbvar should look like when used for custom tabs.

Comment 10

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1904325 - Allow custom tabs to configure navbar colors r=#android-reviewers

Comment 11

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1904325 - Extract color inference methods from CustomTabsToolbarFeature r=#android-reviewers

Allow these to then be used for other similar functionalities, like for how
the navbvar should look like when used for custom tabs.

Comment 12

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1904325 - Allow custom tabs to configure navbar colors r=#android-reviewers

Comment 13

[Petru-Mugurel Lingurar [:petru]]

Not sure why there are multiple of the same patches, seems like they all reference the same differential.
I'll mark some duplicates as obsoletes.

Comment 14

[Petru-Mugurel Lingurar [:petru]]

Attachment: Issues fixed

Comment 15

[Petru-Mugurel Lingurar [:petru]]

Talked with Aarjav and demoed the proposed changes, 3 changes requested:

• don't allow to modify the back button icon of the custom tab, always show the "X"
• don't theme the system navigation bar, always show it as black, even when using a light theme for the app / device
• keep the share button always in the menu. It's okay if it happens to be shown in the menu and in the address bar also.

Comment 16

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1904325 - part 4: Customize which UI elements should be themed for a custom tab r=#android-reviewers

Fenix needs more control over which UI elements to be themes, specifically when
used in combination with the new navigation bar the system bars should be black.

Comment 17

[Petru-Mugurel Lingurar [:petru]]

Attachment: UpdatedCustomTabWithNavbar.mp4

Added a new patch with the changes Aarjav requested.
And here a recording of what the UX would look like which Aarjav approved.

Comment 18

[Chris Peterson [:cpeterson]]

Increasing priority to P1 now that we're fixing toolbar phase 1's beta blockers.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2cba87dc168
part 1: Have both the address bar and the navbar set the custom menu in the same way r=android-reviewers,gl
https://hg.mozilla.org/integration/autoland/rev/f765bf969fcd
part 2: Extract color inference methods from CustomTabsToolbarFeature r=android-reviewers,007
https://hg.mozilla.org/integration/autoland/rev/60d11d4ccb5e
part 3: Allow custom tabs to configure navbar colors r=android-reviewers,007
https://hg.mozilla.org/integration/autoland/rev/d96f1104816f
part 4: Customize which UI elements should be themed for a custom tab r=android-reviewers,mavduevskiy

Comment 20

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/e2cba87dc168
https://hg.mozilla.org/mozilla-central/rev/f765bf969fcd
https://hg.mozilla.org/mozilla-central/rev/60d11d4ccb5e
https://hg.mozilla.org/mozilla-central/rev/d96f1104816f

Comment 21

[Delia Pop (Android QA)]

Attachment: CustomTab_GooglePixel8.JPEG

Verified as fixed on Nightly 130.0a1 from 07/29 with Google Pixel 8 Pro (Android 14).

There are a few known issues affecting custom tabs: 1908316, 1908318, 1908661, 1908662, 1891096 but they will be handled separately.