Open Bug 1910113 Opened 2 years ago Updated 3 months ago

[macOS] Autoselect last message not working when closing (click on x) TB, but not when quitting

Categories

(Thunderbird :: Folder and Message Lists, defect)

Thunderbird 128
Unspecified
macOS
defect

Tracking

(Not tracked)

UNCONFIRMED

People

(Reporter: michaelsincoming-thunderbird, Unassigned, NeedInfo)

References

(Blocks 1 open bug)

Details

(Keywords: regression, regressionwindow-wanted)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.3.1 Safari/605.1.15

Steps to reproduce:

Close/open Thunderbird mail.

Actual results:

Last selected message is not displayed anymore. It seems to go to respective mailbox (I have several), but does not highlight the last selected message from it.

Expected results:

Client should go back to last message. This was working in version 112. Have not tried versions in between. From searching online, it looks like a known issue, but I could not find it in the bug database.

You can use https://mozilla.github.io/mozregression/ to find the regression

If I exit Thunderbird and then start again:
Actual Results:
Last selected email is no longer selected
Thunderbird auto opens on whatever folder was last selected.

Expected Results:
I would not expect Thunderbird to auto open any email and it does as expected.
I would expect Thunderbird to auto open on whatever folder I last selected and it does as expected.

If I select an email in the Inbox
then select another folder and email in that folder
Then return to Inbox

Actual Results:
Last selected email is still selected

Expected Results:
I would expect Thunderbird to auto open any email last selected within same session.
Last selected email is still selected.

Maybe I expect something different from the reporter, because Thunderbird is working as expected for me.

I do not recall that Thunderbird would start up and auto open on any previously selected email, but it does auto open any email that has previously opened in a new tab and display in a tab and it does auto open on last selected folder.

If previously opened emails in a new tab do not occur then it would seem the session file has gone awol OR computer has software to clean up files eg: CCLeaner or WiseCleaner or even some Anit-virus products can perform this 'cleanup' where session files, cache or even passwords can get deleted.

Prior to version 115* people may have used this addon: https://addons.thunderbird.net/en-US/thunderbird/addon/auto-select-latest-message/
But currently not working in 115* see : https://github.com/vanowm/TB-Auto-Select-Latest-Message/pull/6

Let me clarify, maybe this helps understand the issue.

If you have 2 mailboxes, select the e.g. newest message in each. The message pane will show those messages when switching between mailboxes.

Now, close TB, by either closing its Window (click on x) or quitting out of TB. When you open up TB again, the e.g. newest message is not selected anymore and the message pane is empty, and one needs to go back and select the e.g. newest message in each.

So, the status of TB is not the same after re-opening it, e.g. the newest/selected message is not highlighted and the message pane remains empty, until I select them again.

I need to try to restore my older TB to repro it myself, but I am pretty sure this behavior has changed between 112 and 128.

I went back to 112:

When I click on x to close TB, then TB DOES remember the last selected message and message pane is filled in.

However, when I quite TB, the behavior is indeed the same. The last selected message / pane is not retained in either version.

So, the regression with respect to the "click on x" / closing functionality of TB.

I do not use ANY add-ons.

Summary: Autoselect last message → Autoselect last message not working when closing (click on x) TB

I have updated the title to reflect this.

Blocks: tb128found
OS: Unspecified → macOS
Summary: Autoselect last message not working when closing (click on x) TB → [macOS] Autoselect last message not working when closing (click on x) TB, but not when quitting
Keywords: regression
Severity: -- → S4
Component: Untriaged → Folder and Message Lists

Is this seen with the current version 140?

Flags: needinfo?(michaelsincoming-thunderbird)
Flags: needinfo?(anjeyelf)

And, can you use https://mozilla.github.io/mozregression/ to find the regression range?

Tested using beta 141.0b4 - no change - restart of Thunderbird selects preselected folder correctly but does not display any previously selected message in Message Pane.
However, if user opened message in a new tab (typically double click) and has focus on that tab when exiting Thunderbird - upon restart it does open with focus on that opened email in a tab.

Flags: needinfo?(anjeyelf)

Thanks for re-testing this. Looks like a regression to me.

Flags: needinfo?(michaelsincoming-thunderbird)

Do you still want me to find the exact point of regression?

(In reply to Michael from comment #10)

Do you still want me to find the exact point of regression?

Yes. Please see comment 7. Even more detail at https://docs.google.com/document/d/1TaKpLxgajnIrnVKfL_z6SJin4ZCFhst-Szsb0JwDcUk/edit?usp=sharing

Flags: needinfo?(michaelsincoming-thunderbird)

To my knowledge, TB has never restored the last viewed message, only the last viewed folder. There used to be an add-on that selected the last message (which likely no longer works). I believe the bug is INVALID.

I don't have any add-ons installed to my knowledge, and I also just checked in the UI. Is there a definitive way to double-check this?

Flags: needinfo?(michaelsincoming-thunderbird)

To clarify / recap:

  • When quitting TB, it does NOT highlight the last selected message at reopening.
  • However, when clicking on "X" in the TB Window, and it exits out, it DOES highlight the last selected message.
    => This behavior has changed (in my mind a regression) somewhere between 112 and 128.

Well, you meant to say TB 102 ESR? I tried this on Windows and no message is restored. The state at session close is recorded in session.json. If you inspect that, it records the last folder, not the last message. So technically that can never have worked. BTW, the add-on was this:
https://addons.thunderbird.net/en-US/thunderbird/addon/auto-select-latest-message/ - Why have an add-on if it worked out of the box?

Sorry, not following. I am on 110.0b4 (64-bit). MacOS.

Here's the .json after hitting "X" (not quit):

{"rev":0,"windows":[{"type":"3pane","tabs":{"rev":0,"selectedIndex":0,"tabs":[{"mode":"folder","state":{"folderURI":"imap://liost%40yahoo.com@imap.mail.yahoo.com/Thunderbird","folderPaneVisible":true,"messagePaneVisible":true,"firstTab":true},"ext":{"quickFilter":{"filterValues":{"text":{"text":null,"states":{"sender":true,"recipients":true,"subject":true}}},"visible":false}}},{"mode":"calendar","state":{"background":true},"ext":{}}]}}]}

--

Again, I am reporting that auto-select last message works in 110, after exit, and it does not work in 128. I don't have add-ons to my knowledge.

As you can see, nothing in session.json stores the selected message. However, Mac is special. When you close the last 3pane window on Windows or Linux, the application closes, like Mac Quit. There is no chance that on restart, the last message is selected again, hence the need for the add-on.

On Mac however, you can close the last main (3pane) window and the application keeps running. It's possible that when a new window was created, that window somehow restored the last selection state. BTW, I got the analysis from elsewhere, not my original idea. So if that Mac specialty has stopped working, it's likely a supernova regression in TB 115.

I think you are on to something. I can try TB 114 vs 115, and see if your theory holds. However, if it is a ~regression with TB 115, would you actually consider fixing it :) Looks like this behavior is something you did not intend to happen actually, given that quitting TB also does not auto-select the last highlighted message as per design I guess.

(In reply to Michael from comment #19)

I think you are on to something. I can try TB 114 vs 115, and see if your theory holds. However, if it is a ~regression with TB 115, would you actually consider fixing it :) Looks like this behavior is something you did not intend to happen actually, given that quitting TB also does not auto-select the last highlighted message as per design I guess.

Flags: needinfo?(michaelsincoming-thunderbird)
You need to log in before you can comment on or make changes to this bug.