1910321 - [flatpak] Thunderbird tray icon does not work in

Status: RESOLVED WONTFIX

(Thunderbird :: Build Config, defect)

Description

[bbhtt]

Attachment: modified_44800375.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:130.0) Gecko/20100101 Firefox/130.0

Steps to reproduce:

Run thunderbird nightly as Flatpak on GNOME 46

Give it access to --own-nam=org.kde.* so that tray works

Have Appindicator extension installed https://extensions.gnome.org/extension/615/appindicator-support/

Actual results:

No tray icon, it shows 3 dots. See attached image.

Expected results:

Tray should show thunderbird icon.

Comment 1

[bbhtt]

Pretty sure this is because the tray icon name is hardcoded to be TB-symbolic or default-256.png. Inside the Flatpak, icons are named by the FLATPAK_ID. So it would be org.mozilla.Thunderbird.png https://hg.mozilla.org/comm-central/rev/9f64153706e8#l16.66

Comment 2

[bbhtt]

The icon name should likely follow MOZ_APP_REMOTINGNAME, if Thunderbird uses that.

Comment 3

[Wayne Mery (:wsmwk)]

bbhtt, please specify version when possible. If version=128 is not accurate please adjust. Thanks

Comment 4

[Daniel Darnell [:dandarnell]]

Attachment: WIP: Bug 1910321 - Check for Flatpak-specific symbolic system tray icon. r=#thunderbuild

Comment 5

[bbhtt]

I don't think you need to look in /app/share/icons/hicolor for the icons. Flatpak will "export" any icons matching $FLATPAK_ID, installed there to host and make it available under $XDG_DATA_DIRS so that it is automatically found. Just changing the name Thunderbird is using to look for them should be sufficient.

This is exactly how desktop file icons work, you don't make Icon=/app/share/foobar in the desktop file, that works by default.

https://docs.flatpak.org/en/latest/conventions.html#application-icons

Comment 6

[Ryan Lee Sipes]

Following up on this to see if we can bring it to a resolution and close out this bug.

Comment 7

[Daniel Darnell [:dandarnell]]

(In reply to Ryan Lee Sipes from comment #6)

Following up on this to see if we can bring it to a resolution and close out this bug.

Fortunately, thanks to some much appreciated help from Heather, there is still movement happening on this bug. While my WIP patch does what I initially intended it to do (adding a monochrome/symbolic icon to the Flatpak), there seems to be a bigger issue with the tray icon implementation in repackaged versions of Thunderbird on Linux (including the Snap) that prevent it from appearing correctly. She's been taking a look at it.

I'm needinfo-ing her in case she'd like to add anything.

Comment 8

[Heather Ellsworth]

The summary of where I'm at with this at the moment is that I noticed that the beta tarball icon wasn't working on ubuntu but nightly was. This is likely a beta/nightly branding icon issue of some sort. But to see if this fixes it in the snap, i'm working on building a snap with the nightly tarballs.

I think once we fix it in the snap, we'll understand better why it isn't working in the flatpak.