1911496 - Many of WebGPU Unleashed's playgrounds fails to compile shaders w/o automatic type conversion

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect)

Comment 1

[Erich Gubler [:ErichDonGubler] (he/him)]

Billboard also fails: https://shi-yan.github.io/webgpuunleashed/code/code.html#2_05_billboard

Comment 2

[Erich Gubler [:ErichDonGubler] (he/him)]

Fake 3D also fails: https://shi-yan.github.io/webgpuunleashed/code/code.html#2_06_fake_3d

Comment 3

[Erich Gubler [:ErichDonGubler] (he/him)]

Text Rendering fails: https://shi-yan.github.io/webgpuunleashed/code/code.html?highlight=190:204#2_04_text

Comment 4

[Erich Gubler [:ErichDonGubler] (he/him)]

Equirectangle Rendering also fails: https://shi-yan.github.io/webgpuunleashed/code/code.html#5_03_equalrectangle_rendering

Comment 5

[Erich Gubler [:ErichDonGubler] (he/him)]

Mega Texture also fails: https://shi-yan.github.io/webgpuunleashed/code/code.html#5_04_mega_texture

Comment 6

[Erich Gubler [:ErichDonGubler] (he/him)]

Gaussian Splatting also fails: https://shi-yan.github.io/webgpuunleashed/code/code.html#5_08_gaussian_splatting_5

Comment 7

[Andy Leiserson [:aleiserson]]

Many are textureSampleLevel (I am not sure whether that is expected to be addressed immediately by the function database, or may be a more complicated case). mega_texture is pow.

gaussian_splatting_5 is about case selectors, https://github.com/gfx-rs/wgpu/issues/7225. It works in a local build with https://github.com/gfx-rs/wgpu/pull/7250, but is slow, so I noted it in https://bugzilla.mozilla.org/show_bug.cgi?id=1911493#c6.

Comment 8

[Jeff Muizelaar [:jrmuizel]]

mega texture is now:

Shader validation error: Entry point fs_main at Fragment is invalid
   ┌─ :54:12
   │
54 │     return vec4(1.0,0.0,0.0,1.0);
   │            ^^^^^^^^^^^^^^^^^^^^^ instructions after return
   │
   = There are instructions after `return`/`break`/`continue`

Comment 9

[Jeff Muizelaar [:jrmuizel]]

gaussian_splatting_5 now runs.
Billboard still fails with:

Shader validation error: Entry point fs_main at Fragment is invalid
   ┌─ :34:12
   │
34 │     return textureSampleLevel(t_diffuse, s_diffuse, in.tex_coords, 0);
   │            ^^^^^^^^^^^^^^^^^^ naga::ir::Expression [5]
   │
   = Expression [5] is invalid
   = Sample level (exact) type [4] has an invalid type

Comment 10

[Andy Leiserson [:aleiserson]]

The textureSampleLevel issue is bug 1952980 / https://github.com/gfx-rs/wgpu/issues/7488.

I filed bug 1960406 / https://github.com/gfx-rs/wgpu/issues/7536 for the other.

(These bugs are now linked as blockers of the main WebGPU unleashed issue, bug 1911503.)

Comment 11

[Erich Gubler [:ErichDonGubler] (he/him)]

Closing this issue, as the symptoms of this specific bug are closed.