1912642 - [Toolbar redesign] Disabled navigation buttons' colour is incorrect in custom tab (white on white)

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect, P2)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot showing the bug (look at lower left corner where back/forward arrows should be)

Steps to reproduce

1. Change your system theme to light and your Firefox theme to dark.
2. Tap a link in an external app (e.g. gmail) to open a custom tab.

Expected behavior

Navbar at the bottom of the custom tab should have grayed-out/disabled back and forward arrows.

Actual behavior

The left 2/3 of the navbar just looks blank. There are no back and forward arrows.

Device information

• Firefox version: Nightly 131.0a1, datestamp 2024-08-08
• Android device model: Pixel 8
• Android OS version: 14

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot of "good" reference rendering, when Firefox and system are both using light theme

Here's how it looks if both Firefox and Android are using the light theme -- under that configuration, the disabled back/forward arrows are clearly visible.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screencast showing the buttons disappearing when tapped

This bug looks pretty weird when the buttons change from active to inactive, too (e.g. when you've tapped a link, and then tap backarrow, and the button becomes inactive because you can't go back any further).

The button plays the "pressed" expanding-circle animation, but the arrow disappears while the animation is playing, so it sort of just looks like the arrow itself exploded. :)

Comment 3

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:royang, could you have a look please?

For more information, please visit BugBot documentation.

Comment 5

[Roger Yang [:roger]]

Raising severity to match Bug 1916837

Comment 6

[Roger Yang [:roger]]

To reproduce make sure to

Enable toolbar redesign.
Set Firefox Android to dark mode
Set to light mode in system
Open custom tab (using gmail or another app)

Comment 7

[[:skhan]]

Attachment: Bug 1912642 - Fix the navigation bar disabled button color in custom tab

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22abb2db8498
Fix the navigation bar disabled button color in custom tab r=android-reviewers,petru

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/22abb2db8498