1908954 - [toolbar redesign] In custom tab, toolbar/navbar are shown with conflicting light/dark themes, if Firefox theme is different from OS theme

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect, P2)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot of whole screen

Steps to reproduce

1. Set Firefox Nightly to have a different light/dark setting from Android (e.g. set Android to "dark" in settings, and Firefox Nightly to "light" in Firefox settings "customize" section)
2. Tap a link in your email (with Firefox set as your default browser).
3. Look at the Firefox toolbar in the "app tab" that opens.

Expected behavior

Consistently-themed UI, with no jarring differences. In this case, probably all of the UI should be dark-themed since we're adapting to the theme of the app that we were launched from (which is using the system theme).

Actual behavior

• The lower "navbar" is light-themed.
• The rest of the browser/system UI are all dark themed -- Firefox's "main" upper-toolbar (the one with the lock icon, site title and other buttons), the Android gesture-bar at the bottom of my screen, and the system tray at the top of my screen.

Device information

• Firefox version: 130.0a1 2024-07-18
• Android device model: Pixel 8
• Android OS version: 14

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot focusing in on the two toolbars with disagreeing themes

Here's a cropped screenshot to show the relevant portion of the screen.

(note: I also filed bug 1908950 on the fact that there are two backarrow buttons shown here)

Comment 2

[Daniel Holbert [:dholbert]]

(I think this is a new issue as of when the navbar was enabled -- at least, the navbar here is the portion that has the wrong theme -- hence, flagging as a regression from bug 1902798 to get it properly associated with that work. Feel free to adjust/add other bug relationships if there's a preferred way to track navbar bugs.)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1902798

:mavduevskiy, since you are the author of the regressor, bug 1902798, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Daniel Holbert [:dholbert]]

(Er, I forgot the terminology - it looks like we call these "custom tabs" rather than "app tabs", per https://bugzilla.mozilla.org/describecomponents.cgi?product=Fenix . Updating summary.)

Comment 5

[Daniel Holbert [:dholbert]]

Note: there are also a few other bits of UI that are similarly-affected -- I filed bug 1908961 on those. This bug here might really just be a special-case of that more general bug. However, I'd contend that the navbar might deserve its own consideration (and possibly its own nearer-term workaround), since it's more prominent/obvious than the other cases (since it's shown sandwiched-between two other bars of the opposite theme, as shown in the comment 1 screenshot).

Comment 6

[Mike a [:mavduevskiy]]

hey, Daniel! Thanks for reporting the bug, it's so well written! Taking a note how to report bugs for myself ^^

It is possibly fixed in 1904325, the code should have made it into nightly somewhere around this bug was filled. Going through described steps hints that the issue has been resolved.

Could you verify if we can mark it as fixed?

Comment 7

[Daniel Holbert [:dholbert]]

(In reply to Mike a [:mavduevskiy] from comment #6)

hey, Daniel! Thanks for reporting the bug, it's so well written! Taking a note how to report bugs for myself ^^

Thanks! :D

It is possibly fixed in 1904325, the code should have made it into nightly somewhere around this bug was filled. Going through described steps hints that the issue has been resolved.

Yup, this seems fixed. Following the STR, the navbar is dark now (matching the surrounding UI, and taking its coloring from the native theme rather than the Firefox settings). (The popups described in bug 1908961 are still light, so I'll leave that one open.)

Resolving as fixed-by-bug 1904325, or feel free to adjust resolution as you see fit.