1912727 - Contacts sidebar: cannot use the Add to buttons using the keyboard

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[David Bailes]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/127.0.0.0 Safari/537.36

Steps to reproduce:

1. Compose a new message.
2. Ensure that the Contacts sidebar is enabled using the View menu.
3. Using the keyboard, select a contact in the list of contacts in the sidebar.
4. Try to tab to any of the Add to buttons at the bottom of the sidebar, or open the contacts context menu, and choose one of the Add to commands.

Actual results:

The Add to buttons and the Add to commands are unavailable

Expected results:

Should be able to Tab to any of the Add to buttons, or choose any of the Add to commands on the contacts context menu.

Comment 1

[David Bailes]

Initially reported on a Thunderbird mailing list:
https://groups.io/g/thunderbird/topic/what_did_you_do_to_my/107815655

Comment 2

[Anje]

Tested using Windows 10 OS and beta 130.0b1

• In Contacts sidebar
• Use Tab key to get to list of contacts
• use down arrow key to highlight name
• Use 'Tab' key and 'Add to TO' is highlighted
• press 'enter/return' key or space bar

Actual Result
selected name is added to TO field.

Also tried this method

• In Contacts sidebar
• Use Tab key to get to list of contacts
• use down arrow key to highlight name
• use the keyboard key for right click action
• drop down menu appears
• Use arrow key to select eg: Add to Cc
• Press C on keyboard

Actual Result
selected name is added to Cc field.

Not able to reproduce in beta 130.0b1

---

Try again:

Closed Write
Opened new 'Write'
REpeat action to select contact

Notice: Add to TO etc buttons are greyed out - not available
Also the right click drop down buttons are also greyed out.

Use Tab to try to select the Add to To button

Actual REsult:
The From area is selected

Expected REsult
Add to To button is selected

This time I am able to reproduce error in beta 130.0b1

---

Then manually use mouse click to select name in list
'Add to TO' etc buttons become enabled and so does the right click drop down menu items.
All works again

Checking error console for information:
Open Error Console and clear contents
Close Write
check error console and it says

• sizeToContent() is deprecated and will be removed in the future. commonDialog.js:135:10

Click on Write
All buttons still greyed and disabled

recheck Error console - this is now displayed:

• sizeToContent() is deprecated and will be removed in the future. commonDialog.js:135:10
• window.controllers/Controllers is deprecated. Do not use it for UA detection. 2 blank

Temp fix / workaround
mouse click on selected name
'Add to TO' etc buttons all become enabled
All works ok again.

Also tested in TRoubleshoot Mode and got same error.
Noticed: All seemed to work ok until I had started to use the tab key option. Whilst it worked ok initially , after closing Write, all subsequent Write window I opened and attempted to use tab key, it fails.
Hope this information can help discover the cause of this reported bug.

Comment 3

[Anje]

In version 115.13.0

When you click on Write
The 'Add to TO' etc buttons are disabled
Use Tab to get to list of names shown in Contacts Sidebar
use arrow key to highlight contact
All 'Add to To' etc button become enabled.
So no issues in this version.

however this line does get displayed each time you click on 'Write' or 'New Message'

• window.controllers/Controllers is deprecated. Do not use it for UA detection. 2 blank

Comment 4

[Wayne Mery (:wsmwk)]

Thank you for filing the bug report. I am also on that mailing list. I think I also see this, on Mac using nightly build. Ramona, vluc can you reproduce?

From comment 2 ...

Closed Write
Opened new 'Write'
REpeat action to select contact

Notice: Add to TO etc buttons are greyed out - not available
Also the right click drop down buttons are also greyed out.

Use Tab to try to select the Add to To button

Actual REsult:
The From area is selected

Expected REsult
Add to To button is selected

Comment 5

[Ramona Gavrilescu]

Hello,

Managed to reproduce the issues from comment 2 on TB 130.0b1(20240806194349) and 128.0.1esr(20240717233102) using Win 10 and macOS 14.

Closed Write

Opened new 'Write'

Repeat action to select contact
Notice: Add to TO etc buttons are greyed out - not available

Also the right click drop down buttons are also greyed out.
Use Tab to try to select the Add to To button
Actual Result:

The From area is selected
Expected Result:

Add to To button is selected

On TB 115.14.0(20240801155430) it is not reproducible.

Same errors are displayed on the Error console on TB 130.0b1(20240806194349) and 128.0.1esr(20240717233102).

Checking error console for information:

Open Error Console and clear contents

Close Write

Check error console and it says
* sizeToContent() is deprecated and will be removed in the future. commonDialog.js:135:10
Click on Write

All buttons still greyed and disabled
Recheck Error console - this is now displayed:
* sizeToContent() is deprecated and will be removed in the future. commonDialog.js:135:10
* window.controllers/Controllers is deprecated. Do not use it for UA detection. 2 blank

Checked "* window.controllers/Controllers is deprecated. Do not use it for UA detection. 2 blank" on TB 115.14.0(20240801155430) and the error is displayed in the Error console

Comment 6

[Toby Pilling]

Attachment: Bug 1912727 - Fix listener to work for both mouse and keyboard in contacts sidebar list. r=freaktechnik,#thunderbird-front-end-reviewers

== Testing Instructions ==
There are some beautifully clear instructions to reproduce this that are attached to the bug.

Comment 7

[Toby Pilling]

Attachment: Bug 1912727 - Fix listener to work for both mouse and keyboard in contacts sidebar list. r=freaktechnik,#thunderbird-front-end-reviewers

== Testing Instructions ==
There are some beautifully clear instructions attached to the bug. But also..

-Ensure that you have a few contacts
-Ctrl+N
-F9
-Ctrl+W
-Ctrl+N
-Shift+Tab 5 times to enter contacts list
-Down key to select contact
-[buttons should become active]
-Tab
-[Add to To button is next tab option]
-Enter
-[Contact is added to To field]

Try this using the mouse too.

Try run:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=540f59bc767c0ca0a16e3309994b5b840a20f3ac

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/52c70bd6d4d8
Fix listener to work for both mouse and keyboard in contacts sidebar list. r=freaktechnik