1912738 - OAuth prompt appears on every restart

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect, P1)

Description

[Geoff Lankow (:darktrojan)]

Since we started saving the granted OAuth2 scopes in the order given by the authentication server, we seem to be failing to find the refresh token in the password manager because the scopes are listed in a different order from what we expect. This causes the prompt to reappear.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1912738 - Ignore the order of OAuth2 scopes when looking for a refresh token. r=#thunderbird-reviewers

The order is unimportant as long as we have all of the scopes we are looking for.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8e5842f37642
Ignore the order of OAuth2 scopes when looking for a refresh token. r=tobyp

Comment 3

[Francesco]

I tried this in Daily with an O365-based account. The OAuth2 prompt still appears on every restart. Reopen the bug?

Comment 4

[Brendan Abolivier [:babolivier]]

Marking as dupe of bug 1912556 as the patch on there fixes both bugs at once.

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9418808 [details]
Bug 1912738 - Ignore the order of OAuth2 scopes when looking for a refresh token. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1909789
User impact if declined: unnecessary password prompts
Testing completed (on c-c, etc.): manual testing, it's been in four Dailies
Risk to taking this patch (and alternatives if risky): low

Comment 6

[Corey Bryant]

Comment on attachment 9418808 [details]
Bug 1912738 - Ignore the order of OAuth2 scopes when looking for a refresh token. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 130.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/48ca87185397

Comment 8

[Corey Bryant]

Comment on attachment 9418808 [details]
Bug 1912738 - Ignore the order of OAuth2 scopes when looking for a refresh token. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128
Approved for esr115

Comment 9

[Corey Bryant]

Comment deleted.. posted to the wrong bug.

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9418808 [details]
Bug 1912738 - Ignore the order of OAuth2 scopes when looking for a refresh token. r=#thunderbird-reviewers

removing approval for now, to avoid confusion of what is really ready for uplift

Comment 11

[Corey Bryant]

Comment on attachment 9418808 [details]
Bug 1912738 - Ignore the order of OAuth2 scopes when looking for a refresh token. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128

Comment 12

[Daniel Darnell [:dandarnell]]

Thunderbird 128.2.2esr:
https://hg.mozilla.org/releases/comm-esr128/rev/a9c10befa578

Comment 13

[Daniel Darnell [:dandarnell]]

Backed out in Thunderbird 128.2.3esr:
https://hg.mozilla.org/releases/comm-esr128/rev/7ef87ad312ad

Comment 14

[Wayne Mery (:wsmwk)]

For a couple gmail users, 128.2.2 works for them but 128.2.3 does not

• https://support.mozilla.org/en-US/questions/1464812 - logging into an existing account
• https://support.mozilla.org/en-US/questions/1464936 - got 404 setting up an account

Comment 15

[Geoff Lankow (:darktrojan)]

I'm setting this (and the two other bugs) back to fixed, as that's the normal state for bugs that have landed on central. When we manage to find and resolve the problems this caused on 128, I'll make one super-patch of all the changes as I'm tired of dragging 5 patches around.