1922752 - [Uncomposited X11] Scrolling indicator is broken (loss of transparency/contains black background)

Status: VERIFIED FIXED

(Toolkit :: Themes, defect)

Description

[Artem S. Tashkinov]

Attachment: scrolling indicator.webp

Steps to reproduce:

The scrolling indicator (when you middle click the mouse) should have a transparent background, in version 131 it does not.

Actual results:

See the attached screenshot.

Comment 1

[Artem S. Tashkinov]

I'm using the official Mozilla binaries (https://ftp.mozilla.org/pub/firefox/releases/).

OS: Fedora Linux 40
DE: XFCE (Xorg/X11) without compositing

Enabling compositing fixes the issue but it wasn't there previously.

Comment 2

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Core::Panning and Zooming' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Botond Ballo [:botond] [away until Oct 19]]

This seems like a graphics issue.

(In reply to Artem S. Tashkinov from comment #1)

Enabling compositing fixes the issue but it wasn't there previously.

A couple of follow-up questions:

1. Could you clarify whether by "enabling compositing", you're referring to a Firefox setting or a system setting?
2. Would you be able to use mozregression to find out what change introduced the regression?

Comment 4

[Artem S. Tashkinov]

(In reply to Botond Ballo [:botond] from comment #3)

A couple of follow-up questions:

1. Could you clarify whether by "enabling compositing", you're referring to a Firefox setting or a system setting?

Compositing in XFCE's window manager which is XFWM4.

2. Would you be able to use mozregression to find out what change introduced the regression?

I'll try but I cannot promise anything.

Comment 5

[BugBot [:suhaib / :marco]]

:emilio, since you are the author of the regressor, bug 1913104, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1922752 - Use --panel-border-radius for autoscroller. r=#theme

This makes sure that the panel is square if the OS doesn't support
compositing / transparency properly.

While at it, clean-up a bit (use nesting and other variables provided by
popup.css).

Comment 7

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1913104

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c65d0bbb4779
Use --panel-border-radius for autoscroller. r=desktop-theme-reviewers,dao

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c65d0bbb4779

Comment 10

[Artem S. Tashkinov]

That's not all, check bug 1923289

Comment 11

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox132 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9429336 [details]
Bug 1922752 - Use --panel-border-radius for autoscroller. r=#theme

Beta/Release Uplift Approval Request

• User impact if declined: Weird autoscroll popup on non-composited X11
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial-ish styling change.
• String changes made/needed: none
• Is Android affected?: No

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9429336 [details]
Bug 1922752 - Use --panel-border-radius for autoscroller. r=#theme

Approved for 132.0b5.

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/32507fe367b9

Comment 15

[Dianna Smith [:diannaS]]

:emilio since this seems like just a css change, did you want this in the planned dot release or will you let this just ride the trains?

Comment 16

[Emilio Cobos Álvarez [:emilio]]

This bug only affects non-composited desktops which enable autoscroll (so somewhat rare configuration). Given it's mostly cosmetic, I think it's probably better not to uplift to a dot release in a rush.

Comment 17

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Attachment: image (2).png

I was able to reproduce the issue on Firefox 131.0, using Linux Fedora 40 (VM), X11, with compositing disabled, as described in Comment 0.
Verified using Firefox 132.0b6 and Firefox 133.0a1 (2024-10-13), on Linux Fedora 40 (VM), X11, with compositing disabled. The scrolling indicator is now square (as mentioned in Comment 6) and has a gray background with black border.
@emilio, is this the expected UI (attaching a ss as well)? Thanks in advance!

Comment 18

[Emilio Cobos Álvarez [:emilio]]

Yes, that's the expected rendering, thanks.

Comment 19

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Thank you for confirming!
Based on Comment 17 I am marking this verified as fixed.