1914794 - Startup Crash in [@ ews_xpcom::client::impl$0::sync_messages_for_folder_inner::async_fn$0] (MOZ_CRASH Reason: not yet implemented)

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Wayne Mery (:wsmwk)]

First buildid 20240709104114 with this crash signature https://crash-stats.mozilla.org/report/index/11e0b245-f311-4206-91ce-a44f00240712

MOZ_CRASH Reason: not yet implemented

Top 10 frames:

0  xul.dll  MOZ_Crash(char const*, int, char const*)  mfbt/Assertions.h:317
0  xul.dll  RustMozCrash(char const*, int, char const*)  mozglue/static/rust/wrappers.cpp:18
1  xul.dll  mozglue_static::panic_hook(core::panic::panic_info::PanicInfo*)  mozglue/static/rust/lib.rs:98
1  xul.dll  core::ops::function::FnOnce::call_once(void (*)(core::panic::panic_info::Pani...  /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/ops/function.rs:250
1  xul.dll  core::ops::function::FnOnce::call_once<void (*)(ref$<core::panic::panic_info:...  /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/ops/function.rs:250
2  xul.dll  alloc::boxed::impl$50::call()  library/alloc/src/boxed.rs:2036
2  xul.dll  std::panicking::rust_panic_with_hook()  library/std/src/panicking.rs:799
3  xul.dll  std::panicking::begin_panic_handler::closure$0()  library/std/src/panicking.rs:656
4  xul.dll  std::sys_common::backtrace::__rust_end_short_backtrace<std::panicking::begin_...  library/std/src/sys_common/backtrace.rs:171
5  xul.dll  std::panicking::begin_panic_handler()  library/std/src/panicking.rs:652

bp-0f763b01-5278-4703-adb6-c8bb50240717 user reports "Creashes when trying to fetch mail with Office Outlook (Exchange hosted by MS)"

Comment 1

[Brendan Abolivier [:babolivier]]

Looking at bp-0f763b01-5278-4703-adb6-c8bb50240717, it looks like this is caused by our use of todo!() when syncing folder changes that include deletions, which makes the Rust code panic.

Comment 2

[Wayne Mery (:wsmwk)]

Mac+Linux are ews_xpcom::client::XpComEwsClient::sync_messages_for_folder_inner::{{closure}}

Comment 3

[Wayne Mery (:wsmwk)]

(In reply to Brendan Abolivier [:babolivier] from comment #1)

Looking at bp-0f763b01-5278-4703-adb6-c8bb50240717, it looks like this is caused by our use of todo!() when syncing folder changes that include deletions, which makes the Rust code panic.

Who might be able to provide a potential patch?

Comment 4

[Brendan Abolivier [:babolivier]]

(In reply to Wayne Mery (:wsmwk) from comment #3)

(In reply to Brendan Abolivier [:babolivier] from comment #1)

Looking at bp-0f763b01-5278-4703-adb6-c8bb50240717, it looks like this is caused by our use of todo!() when syncing folder changes that include deletions, which makes the Rust code panic.

Who might be able to provide a potential patch?

Eliminating the crash should be fairly straightforward for anyone with a bit of familiarity with Rust. What's needed is to change todo!() calls into e.g. error logs here: https://searchfox.org/comm-central/rev/5e8e75f9c60ffee9c773850f1e31f5878df3f92b/rust/ews_xpcom/src/client.rs#331-335

This will eliminate the crash, but support for processing message deletion or update from the server won't be implemented, that requires a bit more involvement with Thunderbird's storage layer - although I think we'd accept patches for this until we get round to it ourselves.

Comment 5

[Toby Pilling]

Attachment: Bug 1914794 - Avoid crashing (todo!) for delete and server update calls. r=babolivier,leftmostcat,ikey

No actual implementation but replaced todo! with error logging to avoid crashes.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/eddf10177293
Avoid crashing (todo!) for delete and server update calls. r=babolivier

Comment 7

[Alessandro Castellani [:aleca]]

backed out for causing build failures https://hg.mozilla.org/comm-central/rev/b69bf1dc956dba61f2dc9aad06abe9742c9472e9

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/95f16d9cb9d8
Avoid crashing (todo!) for delete and server update calls. r=babolivier

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d002fd222573
Follow-up to fix code formatting. rs=bustage-fix DONTBUILD