1916506 - gProfiles init runs after we notify that idle tasks are finished

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect, P2)

Description

[:Gijs (he/him)]

This seems wrong:

https://searchfox.org/mozilla-central/rev/aee7c3a0dbf33af0c4f6648f391db62b35895e50/browser/base/content/browser-init.js#911-924

// This should always go last, since the idle tasks (except for the ones with
// timeouts) should execute in order. Note that this observer notification is
// not guaranteed to fire, since the window could close before we get here.
scheduleIdleTask(() => {
  this.idleTasksFinished.resolve();
  Services.obs.notifyObservers(
    window,
    "browser-idle-startup-tasks-finished"
  );
});

scheduleIdleTask(() => {
  gProfiles.init();
});

(searchfox unfortunately doesn't seem to have figured out the right blame here, but the original code that was moved to browser-init.js was already using this order)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1883155

:niklas, since you are the author of the regressor, bug 1883155, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Pascal Chevrel:pascalc]

Gijs, is there an end user impact? Thanks

Comment 3

[:Gijs (he/him)]

(In reply to Pascal Chevrel:pascalc from comment #2)

Gijs, is there an end user impact? Thanks

Probably not as the new profiles work is disabled everywhere right now. So could mark 131 and earlier disabled. Assuming, of course, that we don't need to run this code in order for the UI to be disabled/hidden. Passing needinfo to Jared for that.

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Profiles work is behind a build flag as well as a pref right now, so this shouldn't break anything for any end users until we flip the switch in bug 1894239, currently targeting 133.

Comment 5

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

I'm already touching gProfiles in bug 1883162, so I'll fix this along the way

Comment 6

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1916506 - Init gProfiles before the end of the startup idle init block. r?niklas

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2ca30d0148f
Init gProfiles before the end of the startup idle init block. r=niklas

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e2ca30d0148f