1916574 - Toolbar bottom border missing after bug 1916004

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Sam Johnson]

After bug 1916004, when sidebar.revamp=false, the bottom border of the toolbar is missing. The border re-appears when setting sidebar.revamp=true.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1916004

:emilio, since you are the author of the regressor, bug 1916004, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Can you post a screenshot? It's there here, at least... Though it is a lot more subtle with the pref set to false because the pref set to true adds an extra shadow under the border, which makes it contrast more.

Comment 3

[Kestrel]

Attachment: Comparison showing toolbar bottom border no longer visible

The toolbar bottom border is no longer visible on Ubuntu 24.04 with System theme with sidebar.revamp = false. Toggling the bookmarks toolbar, opening a new tab page or changing the theme does not make any difference.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fea1de67d6a8db7b7a7546533a281e55fd3d7169&tochange=a1203aa11e65fbab12d63076469cb818d4656089

Regressed by Bug 1916004.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Will look, likely DPI dependent...

Comment 5

[Sam Johnson]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

Will look, likely DPI dependent...

Ah, that seems to be the case--I see no border on a 1x display, but if I drag the window to a 2x display, a border appears.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1916574 - Make sure the content separator isn't eaten by antialiasing in non-hidpi displays. r=#theme

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba762b4440ab
Make sure the content separator isn't eaten by antialiasing in non-hidpi displays. r=desktop-theme-reviewers,dao

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ba762b4440ab

Comment 9

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 132.0a1 (2024-09-03). The issue is more visible when setting theme to Dark and then opening a new tab. No border under the toolbar will be displayed.
The issue has been verified fixed with Firefox 132.0b2 on Windows 10x64, macOS 12, and Ubuntu 24. The border is displayed as expected.