1917551 - Sidebar no longer has a top border with sidebar.revamp = false

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect)

Description

[Kestrel]

Attachment: Sidebar top border missing on Ubuntu 24.04

STR:

1. Make sure sidebar.revamp = false (default).
2. Disable the bookmarks toolbar on the new tab page to avoid it interfering.
3. Open the History sidebar (Ctrl+H).

The sidebar no longer has a top border. On Linux, one of the sidebar splitter borders is left hanging in free space. Windows 11 is also affected but the single pixel splitter makes it less noticeable.

Bug 1916574 fixed the top border for the content but not the sidebar.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fea1de67d6a8db7b7a7546533a281e55fd3d7169&tochange=a1203aa11e65fbab12d63076469cb818d4656089

Regressed by Bug 1916004.

Comment 1

[Kestrel]

Attachment: Sidebar top border missing on Windows 11

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1916004, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1917551 - Prevent sidevar.revamp=false sidebar from blending with the toolbox. r=#theme

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7468fab929ec
Prevent sidevar.revamp=false sidebar from blending with the toolbox. r=desktop-theme-reviewers,tabbrowser-reviewers,dao

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/674add4e8f96
Fix browser_ext_themes_separators.js.

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7468fab929ec
https://hg.mozilla.org/mozilla-central/rev/674add4e8f96