1916787 - Extra empty space in each bugzilla comment when there are no emoji reactions to it

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[aoia7rz7l]

I had to add the following filter rules to uBO for my own sanity after bug 1421401 introduced emoji comment reactions support.

bugzilla.mozilla.org##.comment-reactions > .sums > button.sum[hidden]:upward(.comment-reactions)
bugzilla.mozilla.org##.comment-reactions > .sums > button.sum:not([data-reaction-count="0"]):upward(.comment-reactions):style(display:flex !important;)

Comment 1

[Kohei Yoshino [:kohei]]

Can you please attach screenshots of the before and after?

Comment 2

[Kohei Yoshino [:kohei]]

I see an extra space when I’m signing out, but not sure if it’s the same issue as what you see. It seems the uBlock Origin filters are not working in my browser.

Comment 3

[aoia7rz7l]

Attachment: before.png

Comment 4

[aoia7rz7l]

Attachment: after.png

Comment 5

[aoia7rz7l]

(In reply to Kohei Yoshino from comment #2)

I see an extra space when I’m signing out, but not sure if it’s the same issue as what you see. It seems the uBlock Origin filters are not working in my browser.

Indeed the issue is not reproducible when logged in.

Comment 6

[Kohei Yoshino [:kohei]]

Gotcha. Thanks for the clarification!

Comment 7

[BMO Github Automation]

Attachment: [mozilla-bteam/bmo] Bug 1916787 - Extra empty space in each bugzilla comment when there are no emoji reactions to it (#2314)

Comment 8

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/24fab8cd40c1c87834c331eb1d6407c2a820a12d