1919237 - Extra empty space in each bugzilla comment when there are no emoji reactions to it and logged in on old bugs that disallow reactions

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Manuel Bucher [:manuel]]

Example link: https://bugzilla.mozilla.org/show_bug.cgi?id=1000000#c0

Comment 1

[David Lawrence [:dkl]]

I do not feel like the space is too that much personally and should not be of an issue. You can attach a screenshot of what it looks like for you in case there is an edge case that we have missed.

Comment 2

[Manuel Bucher [:manuel]]

Attachment: logged-out.png

Comment 3

[Manuel Bucher [:manuel]]

Attachment: logged-in.png

Comment 4

[Manuel Bucher [:manuel]]

Attachment: logged-in-and-out-mashed-together.png

Comment 5

[Manuel Bucher [:manuel]]

Sorry for not attaching screenshots for the cosmetic issue right away.

Comment 6

[David Lawrence [:dkl]]

No worries. I see now where this extra space is not ideal. Kohei, do you have a moment to look at this? Seems that the logic just needs to change to take into account if the user is logged in, reactions are disabled due to being old, and that the bug is older than 3 months. If so, then do not include the <div> at all.

Comment 7

[Kohei Yoshino]

Will work on this today.

Comment 8

[BMO Github Automation]

Attachment: [mozilla-bteam/bmo] Bug 1919237 - Extra empty space in each bugzilla comment when there are no emoji reactions to it and logged in on old bugs that disallow reactions (#2323)

Comment 9

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/c63974b7e872ea15e7a41685c8d6eeb812431964