Closed
Bug 1916829
Opened 1 year ago
Closed 1 year ago
Replace --in-content-warning-icon-color variable with the --icon-color-warning token
Categories
(Toolkit :: Themes, task)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
132 Branch
| Tracking | Status | |
|---|---|---|
| firefox132 | --- | fixed |
People
(Reporter: hjones, Assigned: jabramson, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [recomp][lang=css])
Attachments
(1 file)
We currently only use --in-content-warning-icon-color in a single place in the migration wizard. The values in light/dark theme are similar enough to --icon-color-warning that removing and replacing the --in-content- variable shouldn't cause any issues (though I think we may want to re-visit the yellow in light mode at some point). Another small win here is we'll have a color defined for HCM themes, which --in-content- variable doesn't have.
|
||
Updated•1 year ago
|
|
Assignee | |
Updated•1 year ago
|
Assignee: nobody → jabramson
|
|
Assignee | |
Comment 1•1 year ago
|
||
Pushed by cmeador@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f88a9b7f1524
Use new icon-color-warning CSS token r=cmkm,desktop-theme-reviewers,hjones
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox132:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•