Closed Bug 1916834 Opened 1 year ago Closed 1 year ago

Replace --in-content-success-icon-color variable with the --icon-color-success token

Categories

(Toolkit :: Themes, task)

Product:
Toolkit
Component:
Themes
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
133 Branch
Tracking Flags:
Tracking Status
firefox133 --- fixed

People

(Reporter: hjones, Assigned: jabramson, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [recomp][lang=css])

Attachments

(1 file)

Bug 1916834 - Use new icon-color-success CSS token r=cmkm
48 bytes, text/x-phabricator-request
Details | Review

We currently only use --in-content-success-icon-color in a two places and the values are similar enough to --icon-color-success that removing and replacing the variable shouldn't cause any issues. Another small win here is we'll have a color defined for HCM themes, which the --in-content- variable doesn't have.

Assignee: nobody → jabramson

Looks like this never landed and now needs to be rebased.

Flags: needinfo?(jabramson)
Flags: needinfo?(hjones)
Pushed by dtownsend@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/799d2e44af78 Use new icon-color-success CSS token r=cmkm,desktop-theme-reviewers,credential-management-reviewers,hjones,dimi
Flags: needinfo?(hjones)

https://hg.mozilla.org/mozilla-central/rev/799d2e44af78

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox133: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
Flags: needinfo?(jabramson)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: