Closed
Bug 1916834
Opened 1 month ago
Closed 2 days ago
Replace --in-content-success-icon-color variable with the --icon-color-success token
Categories
(Toolkit :: Themes, task)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
133 Branch
Tracking | Status | |
---|---|---|
firefox133 | --- | fixed |
People
(Reporter: hjones, Assigned: jabramson, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [recomp][lang=css])
Attachments
(1 file)
We currently only use --in-content-success-icon-color
in a two places and the values are similar enough to --icon-color-success
that removing and replacing the variable shouldn't cause any issues. Another small win here is we'll have a color defined for HCM themes, which the --in-content-
variable doesn't have.
Updated•1 month ago
|
Assignee | ||
Updated•23 days ago
|
Assignee: nobody → jabramson
Assignee | ||
Comment 1•22 days ago
|
||
Comment 2•4 days ago
|
||
Looks like this never landed and now needs to be rebased.
Flags: needinfo?(jabramson)
Flags: needinfo?(hjones)
Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/799d2e44af78
Use new icon-color-success CSS token r=cmkm,desktop-theme-reviewers,credential-management-reviewers,hjones,dimi
Reporter | ||
Updated•3 days ago
|
Flags: needinfo?(hjones)
Comment 4•2 days ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 2 days ago
status-firefox133:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
Assignee | ||
Updated•2 days ago
|
Flags: needinfo?(jabramson)
You need to log in
before you can comment on or make changes to this bug.
Description
•