1917090 - EWS: Disable "gethostname" feature in mail-builder (ews_xpcom dependency)

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Rob Lemley [:rjl]]

ews_xpcom -> mail-builder -> gethostname (optional) -> windows-targets 0.48

The issue is with windows-targets depending rather large binary blobs. For version 0.52, Firefox has a workaround to avoid vendoring those dependencies. However, gethostname depends on an older version so they end up getting pulled in by cargo vendor anyway.

ews_xpcom's use of mail-builder doesn't require gethostname, so the idea is to disable the (default) gethostname feature and avoid pulling in the older windows-targets and its dependencies.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1917090 - Disable "gethostname" feature of mail-builder crate. r=#thunderbird-reviewers

Avoids pulling in the binary windows-target dependencies.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9761f3c1173f
Disable "gethostname" feature of mail-builder crate. r=ikey

Comment 3

[Corey Bryant]

Comment on attachment 9423032 [details]
Bug 1917090 - Disable "gethostname" feature of mail-builder crate. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 4

[Rob Lemley [:rjl]]

Comment on attachment 9423032 [details]
Bug 1917090 - Disable "gethostname" feature of mail-builder crate. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): 1895317
User impact if declined: Zero to none. The gethostname crate code should be getting dropped by the linker since it's never actually called by our code. (ews_xpcom)
Testing completed (on c-c, etc.): nightly, going to beta
Risk to taking this patch (and alternatives if risky):
I'd call this low risk. EWS is disabled by pref in 128, but still built. Even so, the above does still apply.

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 131.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/c919910f7f1f

Comment 6

[Corey Bryant]

Comment on attachment 9423032 [details]
Bug 1917090 - Disable "gethostname" feature of mail-builder crate. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128

Comment 7

[Daniel Darnell [:dandarnell]]

This does not want to merge into 128 cleanly. I think we need a 128-specific patch.

Comment 8

[Rob Lemley [:rjl]]

Comment on attachment 9423032 [details]
Bug 1917090 - Disable "gethostname" feature of mail-builder crate. r=#thunderbird-reviewers

Withdrawing c-esr128 for now.