1917730 - Firefox thinks some large phones are tablets and is requesting desktop sites

Status: RESOLVED INVALID

(GeckoView :: General, defect)

Description

[Chris Peterson [:cpeterson]]

GeckoView's HardwareUtils checks for "large" and "small" tablets. If large phones are detected as "small tablets", maybe we should only default to the desktop UA string on large tablets.

https://searchfox.org/mozilla-central/rev/0386e3e47504286ee176ab373a0562262e7c98b4/mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/HardwareUtils.java#28-35

Some phones that are showing desktop sites:

• the Nokia x20 according to this Reddit comment: https://www.gsmarena.com/nokia_x20-10838.php
• the Sony Xperia 1 IV according bug 1790516 comment 20: https://www.gsmarena.com/sony_xperia_1_iv-11521.php

Comment 1

[:gerard-majax]

If you can surface something in about:support ?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:calu, since you are the author of the regressor, bug 1790516, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[thomasdickescheid]

My Pixel 8 also displayed desktop sites after a fresh install of Nightly. I "fixed" it by synchronizing it with my old phone.

Comment 4

[Cathy Lu [:calu]]

Thanks Thomas for the device info!
Do you have any system display settings such as font or display size set? You can check that by connecting your device and in a command line, running adb shell wm density.

Comment 5

[Jason Khew [:Js0n]]

Tried both of my devices, both running on:

132.0a1 (Build #2016043623), hg-ebf0e33ba93e+
GV: 132.0a1-20240910090327
AS: 132.20240907050348

Reproduced: Google Pixel 8 Pro

Physical density: 360
Override density: 306

Can NOT Reproduce: Xiaomi Poco X3 Pro

Physical density: 440
Override density: 396

Comment 6

[Aaron Train [:aaronmt]]

User with a Pixel 9P XL reporting desktop sites served similarly here. https://www.reddit.com/r/firefox/comments/1fdnihk/firefox_nightly_on_android_pulling_up_desktop/

Comment 7

[:gerard-majax]

(In reply to Cathy Lu [:calu] from comment #4)

Thanks Thomas for the device info!
Do you have any system display settings such as font or display size set? You can check that by connecting your device and in a command line, running adb shell wm density.

Could we surface all the kind of relevant infos in about:support to make it easier for diagnosis? When I first got the issue on my Xperia 1 V, my first check was this and nothing was surfaced so I assumed fastmail regressed rather than us

Comment 8

[Cathy Lu [:calu]]

That's a good idea, I would recommend filing a separate bug for adding that information to about:support.

Comment 9

[:gerard-majax]

(In reply to Cathy Lu [:calu] from comment #4)

Thanks Thomas for the device info!
Do you have any system display settings such as font or display size set? You can check that by connecting your device and in a command line, running adb shell wm density.

Sony Xperia 1 V reports:

$ adb shell wm density
Physical density: 420
Override density: 356

Comment 10

[Cathy Lu [:calu]]

Android member reported desktop mode on Pixel 9 Pro Fold as well: "I am seeing that google searches use the large screen version while folded, which makes the text too small to read. in some cases, the sidebar of the search is even empty which looks problematic. "

Comment 11

[Cathy Lu [:calu]]

We're closing this as new changes have landed. Please open if you see other issues.