1790516 - Should GeckoView default to desktop mode UA on tablets? (like iPad Safari)

Reporter

Description

•

2 years ago

We have some long-standing issues on Android tablets because Fenix sends a "Mobile" UA on tablets, but some mobile sites aren't usable on a large tablet screen. (For example, see like https://github.com/mozilla-mobile/fenix/issues/1848 and https://github.com/webcompat/web-bugs/issues/107331.)

These tablet issues don't affect other mobile browsers because:

iPad Safari's UA matches desktop Safari's UA. Users can switch to an iPhone UA if the desktop site is unusable.
Chrome's UA on tablets mentions "Android", but not "Mobile" or "Tablet". Users can switch to a desktop UA if the Android-without-Mobile site is unusable.
Legacy Fennec used to send a "Tablet" UA instead of "Mobile". Fenix never implemented this, so it always sends "Mobile". Users can switch to a desktop UA if the mobile site is unusable.

We'd like to follow Safari's approach: when running on a tablet, default to the desktop mode UA and allow users to switch back to the mobile UA. We debated following Chrome's approach, sending an Android-without-Mobile UA, but that is riskier because that's a new and untested UA string. Also, websites would detect "Android" in the UA and show annoying popups promoting their Android apps.

We want to make this change in GeckoView instead of the Fenix frontend because we want all GeckoView-based apps (including Focus and third-party apps) to have an improved user experience on tablets.

I think we can fix this without adding an new UI by changing GeckoView to check if it's running on a tablet when it initializes mDesktopMode:

https://searchfox.org/mozilla-central/search?q=mDesktopMode&redirect=false

How do we know if we are running on a tablet? I don't know.

Chris Peterson [:cpeterson]

Reporter

Comment 1

•

2 years ago

Before committing to this approach, we need to test whether the desktop mode UA or the Android-without-Mobile UA fixes more of the sites reported to be unusable on tablets.

Updated

•

2 years ago

Priority: P2 → P3

Makoto Kato [:m_kato]

Comment 2

•

2 years ago

iPadOS14+ has both UA and default setting is desktop UA. So I think that we change Fenix's (android-component) default to USER_AGENT_MODE_DESKTOP if the device is Tablet.

Makoto Kato [:m_kato]

Comment 3

•

2 years ago

I found that we return Tablet UA until Fennec 68. But the latest GV returns Mobile UA. As long as our code, we should return tablet UA if tablet. But due to the bug that is explained by bug 1798617, we returns Mobile UA unfortunately.

Jamie Kitson

Comment 4

•

2 years ago

Has this been implemented recently? Version 109 has caused websites to serve desktop (tablet?) versions on my Surface Duo. Please see bug 1807209 for details.

Makoto Kato [:m_kato]

Comment 5

•

2 years ago

Has this been implemented recently? Version 109 has caused websites to serve desktop (tablet?) versions on my Surface Duo. Please see bug 1807209 for details.

Even if 109, UA on tablet device keep mobile. We don't decide future plan yet.

Chris Peterson [:cpeterson]

Reporter

Comment 6

•

2 years ago

Tasks and enhancements should have severity N/A.

Severity: S3 → N/A

Chris Peterson [:cpeterson]

Reporter

Updated

•

2 years ago

Blocks: improved-tablet-support

status-firefox104: wontfix → ---

status-firefox105: wontfix → ---

status-firefox106: wontfix → ---

Component: General → Core

Summary: GeckoView should default to desktop mode UA on tablets → Should GeckoView should default to desktop mode UA on tablets? (like iPad Safari)

Makoto Kato [:m_kato]

Updated

•

2 years ago

Blocks: 1825465

Will

Comment 7

•

9 months ago

Google now doing this with Chrome on "premium" tablets https://developer.chrome.com/blog/desktop-mode?hl=en

Chris Peterson [:cpeterson]

Reporter

Comment 8

•

7 months ago

Chrome's criteria for deciding whether an Android tablet is "premium" is defined by display size (in inches), display pixels, and memory here:

https://source.chromium.org/chromium/chromium/src/+/main:chrome/android/java/src/org/chromium/chrome/browser/tab/RequestDesktopUtils.java;l=223-250;drc=38dd4544f7d62fa087627be4c827af525b65be59

    /**
     * Determines whether the desktop site global setting should be enabled by default.
     * @param displaySizeInInches The device primary display size, in inches.
     * @param context The current context.
     * @return Whether the desktop site global setting should be default-enabled.
     */
    static boolean shouldDefaultEnableGlobalSetting(double displaySizeInInches, Context context) {
        // Do not default-enable if memory is below threshold.
        if (SysUtils.amountOfPhysicalMemoryKB()
                < DEFAULT_GLOBAL_SETTING_DEFAULT_ON_MEMORY_LIMIT_THRESHOLD_MB
                        * ConversionUtils.KILOBYTES_PER_MEGABYTE) {
            return false;
        }

        // Do not default-enable for x86 devices.
        if (!isCpuArchitectureArm()) {
            return false;
        }

        // Do not default-enable on external display.
        if (isOnExternalDisplay(context)) {
            return false;
        }

        // Do not default-enable if the screen size in inches is below threshold.
        if (displaySizeInInches < DEFAULT_GLOBAL_SETTING_DEFAULT_ON_DISPLAY_SIZE_THRESHOLD_INCHES) {
            return false;
        }

        // Do not default-enable if the smallest screen size in dp is below threshold.
        if (context.getResources().getConfiguration().smallestScreenWidthDp
                < DEFAULT_GLOBAL_SETTING_DEFAULT_ON_SMALLEST_SCREEN_WIDTH_THRESHOLD_DP) {
            return false;
        }

        ...

And the default values are defined here:

https://source.chromium.org/chromium/chromium/src/+/main:chrome/android/java/src/org/chromium/chrome/browser/tab/RequestDesktopUtils.java;l=73-75;drc=aaed62d98a863a6ba93615e538321525a11bdebd

    static final double DEFAULT_GLOBAL_SETTING_DEFAULT_ON_DISPLAY_SIZE_THRESHOLD_INCHES = 10.0;
    static final int DEFAULT_GLOBAL_SETTING_DEFAULT_ON_SMALLEST_SCREEN_WIDTH_THRESHOLD_DP = 600;
    static final int DEFAULT_GLOBAL_SETTING_DEFAULT_ON_MEMORY_LIMIT_THRESHOLD_MB = 6500;

Keywords: parity-chrome, parity-safari

Mr. Beedell, Roke Julian Lockhart

Comment 9

•

7 months ago

https://bugzilla.mozilla.org/show_bug.cgi?id=1790516#c8

The decision to exclude all but ARM from this seems strange. RISC-V and especially x86* devices can certainly benefit from the same logic afforded to ARM devices — my x86-64 (LINX 1010b) tablets are smaller than my ARM tablets.

BMO Automation

Updated

•

5 months ago

Component: Core → General

Cathy Lu [:calu]

Assignee

Updated

•

2 months ago

Whiteboard: [fxdroid] [group4]

Jira Integration Bot

Updated

•

2 months ago

See Also: → https://mozilla-hub.atlassian.net/browse/FXDROID-2494

Cathy Lu [:calu]

Assignee

Updated

•

2 months ago

Assignee: nobody → calu

Cathy Lu [:calu]

Assignee

Comment 10

•

2 months ago

Attached file Bug 1790516 - Default desktop mode for tablets (obsolete) — Details

Phabricator Automation

Updated

•

2 months ago

Attachment #9416885 - Attachment description: WIP: Bug 1790516 - Default desktop mode for tablets → Bug 1790516 - Default desktop mode for tablets

Cathy Lu [:calu]

Assignee

Updated

•

2 months ago

Blocks: 1910768

Cathy Lu [:calu]

Assignee

Updated

•

2 months ago

Blocks: 1912488

Pulsebot

Comment 11

•

1 month ago

Pushed by calu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7ae3f62621b8 Default desktop mode for tablets r=geckoview-reviewers,android-reviewers,owlish,007

tszentpeteri

Comment 12

•

1 month ago

Backed out for causing gv-unit failures on GeckoInputStreamTest#multipleWriters.

[task 2024-09-05T14:59:53.678Z] 14:59:53     INFO -  TEST-START | org.mozilla.geckoview.GeckoInputStreamTest#multipleWriters
[task 2024-09-05T14:59:53.710Z] 14:59:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: numtests=1162
[task 2024-09-05T14:59:53.710Z] 14:59:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: stream=
[task 2024-09-05T14:59:53.710Z] 14:59:53     INFO -  org.mozilla.geckoview.test | Error in multipleWriters(org.mozilla.geckoview.GeckoInputStreamTest):
[task 2024-09-05T14:59:53.710Z] 14:59:53     INFO -  org.mozilla.geckoview.test | java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.res.Resources android.content.Context.getResources()' on a null object reference
[task 2024-09-05T14:59:53.711Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.gecko.util.HardwareUtils.init(HardwareUtils.java:29)
[task 2024-09-05T14:59:53.711Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.gecko.util.HardwareUtils.isTablet(HardwareUtils.java:42)
[task 2024-09-05T14:59:53.711Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.gecko.GeckoAppShell.isTablet(GeckoAppShell.java:1253)
[task 2024-09-05T14:59:53.711Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.GeckoSessionSettings.<init>(GeckoSessionSettings.java:382)
[task 2024-09-05T14:59:53.711Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.GeckoSessionSettings.<init>(GeckoSessionSettings.java:354)
[task 2024-09-05T14:59:53.711Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.GeckoSessionSettings$Builder.<init>(GeckoSessionSettings.java:32)
[task 2024-09-05T14:59:53.711Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.<init>(GeckoSessionTestRule.java:875)
[task 2024-09-05T14:59:53.711Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.<init>(GeckoSessionTestRule.java:886)
[task 2024-09-05T14:59:53.711Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.BaseSessionTest.<init>(BaseSessionTest.kt:156)
[task 2024-09-05T14:59:53.712Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.BaseSessionTest.<init>(BaseSessionTest.kt:30)
[task 2024-09-05T14:59:53.712Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.BaseSessionTest.<init>(BaseSessionTest.kt)
[task 2024-09-05T14:59:53.712Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.GeckoInputStreamTest.<init>(GeckoInputStreamTest.java:25)
[task 2024-09-05T14:59:53.712Z] 14:59:53     INFO -  org.mozilla.geckoview.test |
[task 2024-09-05T14:59:53.712Z] 14:59:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
[task 2024-09-05T14:59:53.712Z] 14:59:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: test=multipleWriters
[task 2024-09-05T14:59:53.712Z] 14:59:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: class=org.mozilla.geckoview.GeckoInputStreamTest
[task 2024-09-05T14:59:53.712Z] 14:59:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: stack=java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.res.Resources android.content.Context.getResources()' on a null object reference
[task 2024-09-05T14:59:53.714Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.gecko.util.HardwareUtils.init(HardwareUtils.java:29)
[task 2024-09-05T14:59:53.714Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.gecko.util.HardwareUtils.isTablet(HardwareUtils.java:42)
[task 2024-09-05T14:59:53.714Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.gecko.GeckoAppShell.isTablet(GeckoAppShell.java:1253)
[task 2024-09-05T14:59:53.714Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.GeckoSessionSettings.<init>(GeckoSessionSettings.java:382)
[task 2024-09-05T14:59:53.714Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.GeckoSessionSettings.<init>(GeckoSessionSettings.java:354)
[task 2024-09-05T14:59:53.714Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.GeckoSessionSettings$Builder.<init>(GeckoSessionSettings.java:32)
[task 2024-09-05T14:59:53.714Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.<init>(GeckoSessionTestRule.java:875)
[task 2024-09-05T14:59:53.714Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.<init>(GeckoSessionTestRule.java:886)
[task 2024-09-05T14:59:53.714Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.BaseSessionTest.<init>(BaseSessionTest.kt:156)
[task 2024-09-05T14:59:53.714Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.BaseSessionTest.<init>(BaseSessionTest.kt:30)
[task 2024-09-05T14:59:53.714Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.BaseSessionTest.<init>(BaseSessionTest.kt)
[task 2024-09-05T14:59:53.714Z] 14:59:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.GeckoInputStreamTest.<init>(GeckoInputStreamTest.java:25)
[task 2024-09-05T14:59:53.714Z] 14:59:53     INFO -  org.mozilla.geckoview.test |
[task 2024-09-05T14:59:53.714Z] 14:59:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: current=1
[task 2024-09-05T14:59:53.714Z] 14:59:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS_CODE: -2
[task 2024-09-05T14:59:53.714Z] 14:59:53     INFO -  Printing logcat for test:
[task 2024-09-05T14:59:53.806Z] 14:59:53     INFO -  None
[task 2024-09-05T14:59:53.806Z] 14:59:53  WARNING -  TEST-UNEXPECTED-FAIL | org.mozilla.geckoview.GeckoInputStreamTest#multipleWriters | java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.res.Resources android.content.Context.getResources()' on a null object reference
[task 2024-09-05T14:59:53.807Z] 14:59:53     INFO -  TEST-INFO took 128ms
[task 2024-09-05T14:59:53.807Z] 14:59:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: numtests=1162
[task 2024-09-05T14:59:53.807Z] 14:59:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: stream=
[task 2024-09-05T14:59:53.807Z] 14:59:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
[task 2024-09-05T14:59:53.807Z] 14:59:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: test=writeError
[task 2024-09-05T14:59:53.808Z] 14:59:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: class=org.mozilla.geckoview.GeckoInputStreamTest
[task 2024-09-05T14:59:53.808Z] 14:59:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: current=2
[task 2024-09-05T14:59:53.808Z] 14:59:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS_CODE: 1
[task 2024-09-05T14:59:53.812Z] 14:59:53     INFO -  TEST-START | org.mozilla.geckoview.GeckoInputStreamTest#writeError

Flags: needinfo?(calu)

Pulsebot

Comment 13

•

1 month ago

Pushed by calu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9c1d0c3ff431 Default desktop mode for tablets r=geckoview-reviewers,android-reviewers,owlish,007

Cristian Tuns

Comment 14

•

1 month ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/9c1d0c3ff431

Status: NEW → RESOLVED

Closed: 1 month ago

status-firefox132: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 132 Branch

Ryan VanderMeulen [:RyanVM]

Comment 15

•

28 days ago

I'm guessing we want to nominate this for the Fx132 relnotes. Please go ahead and set the relnote-firefox flag on the bug and fill out the form to do so.

Cathy Lu [:calu]

Assignee

Comment 16

•

27 days ago

Can QE verify that desktop browsing mode is on default for tablets and large screens and off for mobile devices? Thank you

Flags: needinfo?(calu) → qe-verify+

Cathy Lu [:calu]

Assignee

Comment 17

•

27 days ago

QE, this will need to be tested for a variety of sites, including ones with video and popular sites.

Chris Peterson [:cpeterson]

Reporter

Comment 18

•

27 days ago

We should test a foldable device and a large phone (phablet). Those devices are sometimes detected as "tablets", but the desktop site experience might not be appropriate for their screens.

For example, someone on Reddit said Firefox Nightly is detecting their Nokia X20 phone has a tablet and defaulting to desktop sites:

https://www.gsmarena.com/nokia_x20-10838.php

Cathy Lu [:calu]

Assignee

Comment 19

•

27 days ago

Another device mentioned from this bug (https://bugzilla.mozilla.org/show_bug.cgi?id=1917504) is the Google Pixel 9 Pro XL. It should open mobile viewing, since it is not a tablet, but user says it opened desktop mode. I was not able to reproduce the bug with a Firebase device.

:gerard-majax

Comment 20

•

27 days ago

Running Fenix Nightly, buildid 20240907092150, I started having the FastMail webpage showing something similar to the desktop view. Forcing it to desktop view then disabling gets me back the correct view.

Repro on Sony Xperia I V, Android 14.

:gerard-majax

Comment 21

•

27 days ago

When it happens to me (I just repro'd, it's really trivial for me) what would be the thing to check to make sure the issue is related to that bug? Given the timeline and the behavior, I'm confident, but ...

Flags: needinfo?(cpeterson)

Chris Peterson [:cpeterson]

Reporter

Updated

•

27 days ago

Depends on: 1917730

Chris Peterson [:cpeterson]

Reporter

Comment 22

•

27 days ago

Sounds like Fenix is treating some large phones as "small tablets". GeckoView's HardwareUtils checks for "large" and "small" tablets. If large phones are detected as "small tablets", maybe we should only default to the desktop UA string on large tablets.

https://searchfox.org/mozilla-central/rev/0386e3e47504286ee176ab373a0562262e7c98b4/mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/HardwareUtils.java#28-35

I filed bug 1917730 to investigate that.

No longer blocks: 1910768, 1912488

Depends on: 1912488, 1910768

Flags: needinfo?(cpeterson)

Summary: Should GeckoView should default to desktop mode UA on tablets? (like iPad Safari) → Should GeckoView default to desktop mode UA on tablets? (like iPad Safari)

:gerard-majax

Updated

•

27 days ago

Regressions: 1917730

Ryan VanderMeulen [:RyanVM]

Updated

•

25 days ago

No longer depends on: 1917730

Rahul Sainani [:rsainani]

Updated

•

25 days ago

Regressions: 1918029

miralobontiu

Comment 23

•

25 days ago

Verified on the Fenix Nightly 132.0a1 build from 9/11 with the following tablets:

Samsung Galaxy Tab S9 Ultra (Android 14),
Lenovo TB X606X (Android 10),
Huawei MediaPad M3 Lite (Android 7),

and the following foldable phones:

Honor Magic V2 (Android 13) - 7.92 inches screen size unfolded,
Samsung GalaxyZ Fold 4 (Android 13) - 7.6 inches screen size unfolded.

We do not have phablets to test on.

On all the above mentioned devices, we've verified that desktop browsing mode is on default for tablets and large screens.

We've also verified on the following phones that the desktop mode is not ON by default, unless required by the user:

Google Pixel 6 (Android 15),
Oppo Find N2 Flip (Android 14),
Samsung Galaxy S24 (Android 14),
Oppo Find X3 Lite (Android 11).

miralobontiu

Updated

•

25 days ago

status-firefox132: fixed → verified

Flags: qe-verify+

Cathy Lu [:calu]

Assignee

Comment 24

•

24 days ago

Attached file Bug 1790516 - Put desktop mode by default behind a feature flag for debug builds (obsolete) — Details

BugBot [:suhaib / :marco/ :calixte]

Comment 25

•

24 days ago

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Phabricator Automation

Updated

•

23 days ago

Attachment #9424526 - Attachment is obsolete: true

Norisz Fay [:noriszfay]

Comment 26

•

23 days ago

Backed out as requested by developer

Backout link

Status: RESOLVED → REOPENED

status-firefox132: verified → ---

Flags: needinfo?(calu)

Resolution: FIXED → ---

Target Milestone: 132 Branch → ---

Norisz Fay [:noriszfay]

Comment 27

•

23 days ago

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/b91e1b615932

Cathy Lu [:calu]

Assignee

Updated

•

18 days ago

Flags: needinfo?(calu)

Cathy Lu [:calu]

Assignee

Comment 28

•

5 days ago

Closing as this work is being handled by https://bugzilla.mozilla.org/show_bug.cgi?id=1910768.

Status: REOPENED → RESOLVED

Closed: 1 month ago → 5 days ago

Duplicate of bug: 1910768

Resolution: --- → DUPLICATE

Phabricator Automation

Updated

•

5 days ago

Attachment #9416885 - Attachment is obsolete: true

Bug 1790516 - Default desktop mode for tablets 2 months ago Cathy Lu [:calu] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1790516 - Put desktop mode by default behind a feature flag for debug builds 24 days ago Cathy Lu [:calu] 48 bytes, text/x-phabricator-request		Details \| Review