1917783 - Implement `TrustedTypePolicyFactory`'s `getAttributeType`

Status: RESOLVED FIXED

(Core :: DOM: Security, task)

Description

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

https://w3c.github.io/trusted-types/dist/spec/#dom-trustedtypepolicyfactory-getattributetype

Comment 1

[Frédéric Wang (:fredw)]

Attachment: Bug 1917783 - Implement `TrustedTypePolicyFactory`'s `getAttributeType`. r=smaug

Comment 2

[Frédéric Wang (:fredw)]

Attachment: Bug 1917783 - Add more WPT tests for elementNS/attrNs parameters of `getAttributeType`. r=smaug

This overlaps a bit with the following tests:
TrustedTypePolicyFactory-getAttributeType-namespace.html
TrustedTypePolicyFactory-getAttributeType-svg.html

Comment 3

[Frédéric Wang (:fredw)]

Attachment: Bug 1917783 - Add WPT tests for getAttributeType with event handler content attributes. r=smaug

The spec is not really clear, for now add a tentative test with the
cases detected while implementing the method in Firefox. For details,
see https://github.com/w3c/trusted-types/issues/520

Comment 4

[Frédéric Wang (:fredw)]

Attachment: Bug 1917783 - Add WPT test for getAttributeType() with qualified attribute name. r=smaug

See https://github.com/w3c/trusted-types/issues/496#issuecomment-2428834747

Comment 5

[Frédéric Wang (:fredw)]

https://treeherder.mozilla.org/jobs?repo=try&revision=d3b35e87055830a2ba36eb563772e5319e899db3

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9c1c805ef2d
Add more WPT tests for elementNS/attrNs parameters of `getAttributeType`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/474afb5197ff
Add WPT tests for getAttributeType with event handler content attributes. r=smaug
https://hg.mozilla.org/integration/autoland/rev/aba2bd9d817f
Add WPT test for getAttributeType() with qualified attribute name. r=smaug
https://hg.mozilla.org/integration/autoland/rev/51f5ff4856dc
Implement `TrustedTypePolicyFactory`'s `getAttributeType`. r=smaug

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48767 for changes under testing/web-platform/tests

Comment 9

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/d9c1c805ef2d
https://hg.mozilla.org/mozilla-central/rev/474afb5197ff
https://hg.mozilla.org/mozilla-central/rev/aba2bd9d817f
https://hg.mozilla.org/mozilla-central/rev/51f5ff4856dc

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[Donal Meehan [:dmeehan]]

:fredw do you want to nominate this for a release note? (Process info)

Comment 13

[Frédéric Wang (:fredw)]

I think this is only a small method from the Trusted Types spec, so probably not worth nominating it.

Comment 14

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

(In reply to Frédéric Wang (:fredw) from comment #13)

I think this is only a small method from the Trusted Types spec, so probably not worth nominating it.

Also be aware that the method is guarded by a default-disabled pref ([1], [2]).

[1] https://searchfox.org/mozilla-central/rev/783f3fca1dda58353f7d3075744dd48b66e00e5e/dom/webidl/TrustedTypes.webidl#47,55
[2] https://searchfox.org/mozilla-central/rev/783f3fca1dda58353f7d3075744dd48b66e00e5e/modules/libpref/init/StaticPrefList.yaml#3947,3949

Comment 15

[Frédéric Wang (:fredw)]

Right, but that does not seem to prevent a feature from being nominated:

If your feature is ready for testing on the nightly channel but is behind a feature flag and it isn't planned to ship on Beta/Release soon, please nominate it so that we can expose it to our nightly testers.

Comment 16

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

(In reply to Frédéric Wang (:fredw) from comment #15)

Right, but that does not seem to prevent a feature from being nominated:

If your feature is ready for testing on the nightly channel but is behind a feature flag and it isn't planned to ship on Beta/Release soon, please nominate it so that we can expose it to our nightly testers.

Right.

Since support of many APIs with Trusted Types still has to be implemented, I suggest notifying Nightly testers later. Possibly when all APIs for non-Worker code are implemented. Or when another reasonably usable set of APIs is implemented.

Comment 17

[Hamish Willee]

FF133 MDN docs for this can be tracked in https://github.com/mdn/content/issues/36559. As this is very minimal implementation, mostly that is just a compatibility data update, and an experimental features doc section that just makes it clear that there is a lot more to come (essentially, a placeholder).