1925952 - Implement attribute waitingforkey on audio/video elements

Status: RESOLVED FIXED

(Core :: DOM: Events, task)

Description

[Frédéric Wang (:fredw)]

See https://phabricator.services.mozilla.com/D225944#inline-1255920

We could rely on a flag EventNameType_HTMLMedia to handle the media-specific event handler attributes: onencrypted, onwaitingforkey (the later is not handled yet in the method, but not sure how to test that).

Comment 1

[Frédéric Wang (:fredw)]

Attachment: Bug 1925952 - Add test to check we don't escape entities in JS attributes. r=smaug

See callers to nsXMLContentSerializer::IsJavaScript.

Comment 2

[Frédéric Wang (:fredw)]

Attachment: Bug 1925952 - Implement attribute waitingforkey on audio/video elements. r=smaug

Use a flag EventNameType_HTMLMedia to represent event specific to the
media element.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0fa1e56a396
Add test to check we don't escape entities in JS attributes. r=smaug
https://hg.mozilla.org/integration/autoland/rev/4c149b703e82
Implement attribute waitingforkey on audio/video elements. r=smaug

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48763 for changes under testing/web-platform/tests

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/a0fa1e56a396
https://hg.mozilla.org/mozilla-central/rev/4c149b703e82

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 7

[Donal Meehan [:dmeehan]]

:fredw do you want to nominate this for a release note? (Process info)

Comment 8

[Frédéric Wang (:fredw)]

I think this is only a small attribute, so probably not worth putting in the release note. I also didn't send an intent to ship or put it under a flag.

Probably we need to update MDN/BCD, though.

Comment 9

[Hamish Willee]

MDN docs work for this can be tracked in https://github.com/mdn/content/issues/36558

To be clear, what does this deliver? My "guess" is that previously the HTMLMediaElement events waitingforkeys and encrypted were implemented and can be handled using addEventListener(), but the onXxx handlers on the media elements were not implemented - is that correct?

[It is also possible what this means is that the IDL was present but without implementation - so the two events appears are exposed but don't do anyting]

In other words, in browser compatibility data the earlier implementations of the events probably need to be modified to partial implementations and the full implementation only starts in FF133. Right?

Comment 10

[Frédéric Wang (:fredw)]

The IDL attributes were present for a while, this is covered by the following test:

https://searchfox.org/mozilla-central/rev/a4b08999304d15c1e3d30ad279a86924e1a54ade/testing/web-platform/tests/encrypted-media/idlharness.https.html (which uses https://searchfox.org/mozilla-central/rev/a4b08999304d15c1e3d30ad279a86924e1a54ade/testing/web-platform/tests/interfaces/encrypted-media.idl#100)

Support for the content attribute have been implemented in this bug, this is covered by the test I added:
https://searchfox.org/mozilla-central/rev/f8488adfb9c3e25a80ba6a21e04950d58165e956/testing/web-platform/tests/encrypted-media/media-element-event-handler-attributes.html

I actually didn't check whether the implementations of the two IDL attributes, but I assume they were already working since they have some tests:

https://searchfox.org/mozilla-central/search?q=onencrypted%7Conwaitingforkey&path=dom%2Fmedia%2Ftest%2F&case=false&regexp=true
https://searchfox.org/mozilla-central/search?q=waitForEventAndRunStep%28%27waitingforkey&path=testing%2Fweb-platform%2Ftests%2Fencrypted-media&case=false&regexp=false
https://searchfox.org/mozilla-central/search?q=waitForEventAndRunStep%28%27encrypted&path=testing%2Fweb-platform%2Ftests%2Fencrypted-media&case=false&regexp=false

Comment 11

[Hamish Willee]

Sorry Fred, you'd think I'd know the terminology, but I haven't use the term "content attribute" vs "idl attribute" before. I infer it means an attribute you can apply to the tag itself in html, and that you mean that this fix means that you now support onwaitinggforkeys handlers applied to audio and video elements?

Comment 12

[Frédéric Wang (:fredw)]

Right, I meant a test like this was added in 2016:
https://searchfox.org/mozilla-central/rev/b477cd37e845005dac8881427fa06a2771d993db/dom/media/test/test_eme_waitingforkey.html#32 (idl attribute)

while I added a test like this in my patch:
https://searchfox.org/mozilla-central/rev/b477cd37e845005dac8881427fa06a2771d993db/testing/web-platform/tests/encrypted-media/media-element-event-handler-attributes.html#10 (content attribute).

Comment 13

[Hamish Willee]

Thanks! Should all be done now (compat data, mdn release note, and doc for the event (which includes event handler)