1912473 - [Toolbar Redesign] Download complete dialog appears mid-air or overlapped by navigation bar when changing the orientation

Status: VERIFIED FIXED

(Fenix :: Toolbar, defect)

Description

[Delia Pop]

Attachment: Download_BottomToolbar.mp4

Steps to reproduce

1. Download a file (can use https://www.thinkbroadband.com/download for test downloads) while in Portrait mode.
2. Once the "Download completed" dialogue is displayed, change the device orientation to Landscape mode.
3. Observe the "Download completed" dialogue.
4. Repeat Steps 1-3, but vice versa: download a file while in Landscape mode and then change the orientation to Portrait mode.

Expected behavior

The "Download completed" dialogue remains correctly displayed when changing the orientation.

Actual behavior

After Step 3, when changing the orientation from Portrait to Landscape, the "Download complete" dialog is displayed mid-air.
After Step 4, when changing the orientation from Landscape to Portrait, the "Download complete" dialog is partially cutoff by the navigation toolbar.

Device information

• Firefox version: Nightly 130.0a1 from 08/09
• Android device model: Samsung Galaxy S22 Ultra, Xiaomi 12 Pro (Android 13), Google Pixel 8 Pro (Android 14), any phone device

Comment 1

[Delia Pop]

Attachment: Download_TopToolbar.mp4

Comment 2

[Petru-Mugurel Lingurar [:petru]]

This is very similar to bug 1912484 and would probably need a similar approach for fixing.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1912473 - part 1 - Use a dynamic bottom anchor for the download complete dialog r=#android-reviewers

After the recent addition of the navbar the bottom anchor can change for an already
displaying download complete dialog when the screen is rotated or the toolbar position
is changed.
So instead of relying on a hardcoded bottom toolbar height we'll use more frequent
inferences of what the anchor should be and position the dialog based on that.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1912473 - part 2 - Cleanup: avoid passing in a hardcoded anchor height r=#android-reviewers

The anchor (and its height) will be inferred dynamically by the behavior
responsible for placing the download complete dialog above the bottom anchor.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aef989d16ece
part 1 - Use a dynamic bottom anchor for the download complete dialog r=android-reviewers,skhan
https://hg.mozilla.org/integration/autoland/rev/6dc843487c9b
part 2 - Cleanup: avoid passing in a hardcoded anchor height r=android-reviewers,skhan

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/aef989d16ece
https://hg.mozilla.org/mozilla-central/rev/6dc843487c9b

Comment 7

[Delia Pop]

Attachment: OPPO_Trim.mp4

Tested with OPPO A15s (Android 10) and Google Pixel 8 Pro (Android 14) on the latest Nightly 132.0a1 from 09/04 (GV 132.0a1-20240904095513) and I can still partially reproduce (less frequent than before) instances where the "Download complete" dialog is displayed mid-air or partially cutoff by the navigation toolbar when changing the orientation.
Moreover, I get the same result for the case in which the navigation bar and address bar are hidden before the download is finished > then the orientation is changed (as previously described in 1907566.

I'll retest this with tomorrow's Nightly, in case this build did not contain the fix.

Comment 8

[Delia Pop]

Attachment: Nightly_132.mp4

@Petru, I can still partially reproduce this on the latest Nightly 132.0a1 from 09/06.
I'll reopen for further investigation.

Comment 9

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1912473 - Avoid a dependencies chain in placing browser screen views r=#android-reviewers

A recent change introduced returning true in DynamicDownloadDialogBehavior's
layoutDependsOn method to signal to the framework that the download finished dialog
depends on the bottom toolbar.
While technically correct given the complexity of the entire layout the download finished
dialog had it's own View depending on it - the snackbar which may show when users would
tap to open a link in a new tab. And in this scenario we would get a crash.

The approach here comes to restore the previous behavior - return false from the
layoutDependsOn method, written exactly as it was before.

Comment 10

[Phabricator Automation]

Comment on attachment 9423531 [details]
Bug 1912473 - Avoid a dependencies chain in placing browser screen views r=#android-reviewers

Revision D221469 was moved to bug 1917138. Setting attachment 9423531 [details] to obsolete.

Comment 11

[Petru-Mugurel Lingurar [:petru]]

Think this should be fixed now through https://phabricator.services.mozilla.com/D221469

Comment 12

[Delia Pop]

Attachment: Nightly132_0912_QA.mp4

This issue is now verified as fixed on the latest Nightly 132.0a1 from 09/12.
Tested with the following devices:

• Samsung Galaxy A53 5G (Android 14)
• Xiaomi 12 Pro (Android 13)
• OPPO A15s (Android 10)

Comment 13

[Delia Pop]

Attachment: Nightly132_0912_QA.mp4

LE: I've noticed that if the device orientation is changed from Landscape mode to Portrait mode while the download dialog is displayed, the action button is overlapped by the navigation bar, similar to what we had in bug.

The other issue with the dialog being displayed mid-air is no longer reproducible.

I'll leave this ticket closed now, but I'll file a new one for the prompt being overlapped by nav bar.