1918831 - Adjust rules-based notification selection to use targeting.*.displayed_notifications

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Toby Pilling [:tobyp]]

Once the notifications have been fetched from the server, select an appropriate notification to display. In addition to the existing rules using locales, versions, channels and operating_systems, add new logic to support the inclusion or exclusion based on previously seen notifications.

• Once a notification has been selected and shown, there should be a way to target users based on this.
• Once a notification has been clicked, closed or dismissed, a log should be written to record the action so that notification can be marked as ineligible and will not be shown again.

Example scenario - for en-US, we launch with two notifications with the following settings:

A	B
severity="2"	severity="3"
type="donation"	type="donation_old"
targeting.percent_chance="50"	targeting.percent_chance="100"
targeting.include.locales=["en-US"]	targeting.include.locales=["en-US"]
targeting.exclude.displayed_notifications=["f103c749-9932-48bb-8f61-2e8ed2beacc3"]	targeting.exclude.displayed_notifications=["B103c749-9932-48bb-8f61-2e8ed2beacc4"]
id="B103c749-9932-48bb-8f61-2e8ed2beacc4"	id="f103c749-9932-48bb-8f61-2e8ed2beacc3"

From this, we an see that if a user is eligible to see both "A" and "B", there is a 50% chance that "A" will be selected at random. Based on the targeting.exclude logic, a user cannot be eligible to see both "A" and "B". If the user is not randomly selected to see "A", they will be selected to see "B".

If the user is assigned to "A" and then closes it, they will no longer be eligible to see any notifications because the id of "A" is an exclusion for "B", and the id of "A" has been recorded as already being seen and closed.

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1918831 - Implement in-app notification filtering based on displayed_notifications. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/61b3f76ae0c7
Implement in-app notification filtering based on displayed_notifications. r=mkmelin