192014 - Bookmarks menu shows no bookmarks when no unminimized windows are open

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Thomas Lewis]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.2.1) Gecko/20021130
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.2.1) Gecko/20021130

If the appearance preferences are set to not open navigator on startup then the
bookmarks menu will be empty below "Manage Bookmarks..." until the first
navigator window is opened.  Since "Manage bookmarks..." is able to access
bookmarks they should be displayed in Bookmarks menu as well. 

Reproducible: Always

Steps to Reproduce:
1. Set "When mozilla starts up, open:" Navigator to off.
2. Quit and restart Mozilla
3. Look at Bookmarks menu: It only displays up to "Manage Bookmarks..."


Actual Results:  
Bookmarks don't display in bookmarks menu.

Expected Results:  
Bookmarks are displayed below "Manage Bookmarks..."

Comment 1

[Thomas Lewis]

"When Mozilla starts up, open: Mail & Newsgroups" in the Appearance preferences
must be set to On in order for the problem to appear.  Once the Mail window is
closed then the bookmarks menu is available, but empty.

Comment 2

[Greg K.]

Confirmed using FizzillaMach/2003022103.

Comment 3

[Greg K.]

*** Bug 199409 has been marked as a duplicate of this bug. ***

Comment 4

[Chris Casciano]

*** Bug 200414 has been marked as a duplicate of this bug. ***

Comment 5

[sairuh (rarely reading bugmail)]

->jan.

chris, do you think this is a dup of bug 199178?

Comment 6

[Jan Varga [:janv]]

I don't think it's related to bug 199178.
The problem here is that bookmarks are loaded only by calling readBookmarks()
when a new navigator window is opened.

Comment 7

[Chris Lyon]

*** Bug 201113 has been marked as a duplicate of this bug. ***

Comment 8

[Jan Varga [:janv]]

Attachment: patch

Comment 9

[jag (Peter Annema)]

Comment on attachment 122043 [details] [diff] [review]
patch

Could you indent the next lines of |disabledItems| to match up with the array
like it did before?

Thanks for adding AddBookmarkAs and AddGroupmarkAs.

sr=jag with my nit fixed.

/me wonders if we could move the hiddenWindow code out into hiddenWindow.js

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 122043 [details] [diff] [review]
patch

a=sspitzer

Comment 11

[Jan Varga [:janv]]

checked in
I hope this won't regress Txul on Mac.

Comment 12

[G Piper]

Still not working for Mac X on build 2003042908.

Comment 13

[Jan Varga [:janv]]

yeah, it doesn't work in that build, the patch has been checked in only few mins ago

Comment 14

[sairuh (rarely reading bugmail)]

*** Bug 200026 has been marked as a duplicate of this bug. ***

Comment 15

[Greg K.]

Could this have caused bug 204022?

Comment 16

[Chris Petersen]

Verified on the 2003-05-02-08 Macho trunk build