1920717 - Build a linter that checks for global variable with runtime initialization

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[[:sergesanspaille]]

This linter would be quite close to -Wglobal-constructors but it would be aware of MOZ_GLOBAL_CLASS, and of a new attribute MOZ_RUNINIT that explicitly flags global variable that requires runtime initialization.

The goal is to avoid adding such globals (i.e. no regression) and make existing state explicit.

Comment 1

[[:sergesanspaille]]

Attachment: Bug 1920717 - Add static checker for global variables with runtime initialisation r=glandium!

This patch both:

1. Provides a static checker to detect global variables which may not be
   initialized at compile-time

2. Verify that variables flagged as MOZ_RUNINIT are indeed
   initialized at runtime, unless they are also flagged as MOZ_GENERATED
   (to avoid false positive)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39dc4be7fd58
Add static checker for global variables with runtime initialisation r=glandium

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/39dc4be7fd58