1920718 - Flag all global constructor with runtime initialization with a specific attribute

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[[:sergesanspaille]]

That way a linter can consume this attribute and avoid false positive.

Comment 1

[[:sergesanspaille]]

Attachment: Bug 1920718 - Annotate all global variable with runtime initialization attributes r=glandium!

This annotation is only understood by our clang-tidy plugin. It has no
effect on regular compilation.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b1409597101
Annotate all global variable with runtime initialization as MOZ_RUNINIT r=application-update-reviewers,media-playback-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,gfx-reviewers,aosmond,lina,nalexander,aabh

Comment 3

[tszentpeteri]

Backed out for causing Bb bustage on rapl.cpp.

• Backout link
• Push with failures
• Failure Log H:
• Failure Log Bb:

[task 2024-10-08T20:16:46.995Z] 20:16:46     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/tools/power'
[task 2024-10-08T20:16:46.997Z] 20:16:46     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/gcc/bin/g++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -std=gnu++17 -isystem /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/c++/8 -isystem /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/x86_64-linux-gnu/c++/8 -isystem /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/x86_64-linux-gnu -isystem /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include -o rapl.o -c  -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -I/builds/worker/checkouts/gecko/tools/power -I/builds/worker/workspace/obj-build/tools/power -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -D_GLIBCXX_USE_CXX11_ABI=0 -fno-rtti -pthread -fno-sized-deallocation -fno-aligned-new -ffunction-sections -fdata-sections -fno-math-errno -fno-exceptions -pipe -fPIC -gdwarf-4 -O2 -fno-omit-frame-pointer -funwind-tables -Werror -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wlogical-op -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-multistatement-macros -Wno-error=class-memaccess -Wformat -Wformat-overflow=2 -Wno-psabi -Wno-error=builtin-macro-redefined -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/rapl.o.pp   /builds/worker/checkouts/gecko/tools/power/rapl.cpp
[task 2024-10-08T20:16:46.998Z] 20:16:46    ERROR -  /builds/worker/checkouts/gecko/tools/power/rapl.cpp:609:40: error: 'annotate' attribute directive ignored [-Werror=attributes]
[task 2024-10-08T20:16:46.999Z] 20:16:46     INFO -   MOZ_RUNINIT static std::vector<double> gTotals_W;
[task 2024-10-08T20:16:46.999Z] 20:16:46     INFO -                                          ^~~~~~~~~
[task 2024-10-08T20:16:46.999Z] 20:16:46     INFO -  cc1plus: all warnings being treated as errors
[task 2024-10-08T20:16:47.000Z] 20:16:47    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:676: rapl.o] Error 1
[task 2024-10-08T20:16:47.000Z] 20:16:47     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/tools/power'
[task 2024-10-08T20:16:47.000Z] 20:16:47     INFO -  gmake[4]: Target 'target-objects' not remade because of errors.
[task 2024-10-08T20:16:47.001Z] 20:16:47    ERROR -  gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: tools/power/target-objects] Error 2
[task 2024-10-08T20:16:47.005Z] 20:16:47     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/origin-trials'
[task 2024-10-08T20:16:47.005Z] 20:16:47     INFO -  mkdir -p '.deps/'

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9194a7332ece
Annotate all global variable with runtime initialization attributes r=glandium,application-update-reviewers,media-playback-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,gfx-reviewers,aosmond,lina,nalexander,aabh,geckoview-reviewers,win-reviewers,gstoll,m_kato

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/9194a7332ece