1928157 - Port Bug 1920718 - Flag all global constructor with runtime initialization with a specific attribute

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Ben Campbell]

nsMailApp.cpp:154:1: error: Global variable has runtime initialisation, try to remove it, make it constexpr or MOZ_CONSTINIT if possible, or as a last resort flag it as MOZ_RUNINIT.

It's gBootstrap, so following m-c and adding MOZ_RUNINIT.

Possible there might be some more to track down.

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8b1a8a4da370
Annotate gBootstrap with runtime initialization attributes. rs=bustage-fix

Comment 2

[Ben Campbell]

The shutdown handler in comm/mailnews/base/src/FolderCompactor.cpp:582 also needs fixing. I suspect MOZ_RUNINIT is a bad idea and it shouldn't be a RefPtr<>...

And I bet there'll be some more lurking in there.

Comment 3

[[:sergesanspaille]]

If that can help: the ideal is to flag global variable as constexpr. If that doesn't make sense, MOZ_CONSTINIT (a backport of constinit) ensures there's no global constructor associated to that variable. Otherwise MOZ_RUNINIT which basically means there's a runtime initialization associated to that global variable (from a syntactic point of view).

Comment 4

[Ben Campbell]

Attachment: WIP: Bug 1928157 - Stopgap bustage fix. Apply MOZ_RUNINIT to global vars with constructors. rs=bustage-fix

We need to get rid of the bulk of these, but this at least gets us back up and building.

Comment 5

[Ben Campbell]

Attachment: Bug 1928157 - Stopgap bustage fix. Apply MOZ_RUNINIT to global vars with constructors. rs=bustage-fix

We need to get rid of the bulk of these, but this at least gets us back up and building.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0651eba1ffa1
Stopgap bustage fix. Apply MOZ_RUNINIT to global vars with constructors.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6ab306398cb1
Stopgap bustage fix, adding MOZ_RUNINIT to gtest data. rs=bustage-fix

Comment 8

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1928157 - Stopgap bustage fix, adding MOZ_RUNINIT to Windows and Mac specific files. r=#thunderbird-reviewers

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bee199eeb648
Stopgap bustage fix, adding MOZ_RUNINIT to Windows and Mac specific files. r=john.bieling