1920852 - Add ability to close tabs remotely to Firefox View

Status: VERIFIED FIXED

(Firefox :: Sync, enhancement, P1)

Description

[Sammy Khamis [:skhamis]]

Add the ability to close remote tabs to Firefox View. Currently it's on the new Sidebar, synced tabs menu and FxView is another surface this feature should be usable in.

Comment 1

[Sammy Khamis [:skhamis]]

Attachment: Bug 1920852: Add closing tabs remotely to Firefox View r?lina,LougeniaBailey

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a588c633d90b
Add closing tabs remotely to Firefox View r=lina,fxview-reviewers,jsudiaman

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a588c633d90b

Comment 4

[Sammy Khamis [:skhamis]]

Attachment: Bug 1920852: Add closing tabs remotely to Firefox View r?lina,LougeniaBailey

Original Revision: https://phabricator.services.mozilla.com/D223448

Comment 5

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Won't see close remote tabs on all surfaces
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: 1. Open Firefox View
• Risk associated with taking this patch: Low
• Explanation of risk level: It's mainly UI enhancements for Firefox View for closing remote tabs
• String changes made/needed: N/A
• Is Android affected?: no

Comment 6

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Won't see close remote tabs on all surfaces
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: 1. Open Firefox View, 2. Navigate to "Tabs from other devices", 3. Press the new "X" button to close a tab on another device, 4. Should perform similar to synced tabs and sidebar closing
• Risk associated with taking this patch: Low
• Explanation of risk level: It's mainly UI enhancements for Firefox View for closing remote tabs
• String changes made/needed: N/A
• Is Android affected?: no

Comment 7

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Verified that the new "X" button is present and works as expected on Firefox 133.0b2 in Tabs from another device from Firefox View, in Synced tabs and New Sidebar.

Tests were performed on macOS 15.1, Windows 11 and Ubuntu 24.04.

It seems that the "X" button is not present in the old Sidebar. Is this intended Sammy? Thanks!

Comment 8

[Sammy Khamis [:skhamis]]

Hi Catalin!

Yes that is correct that closing remote tabs should not be present/not implemented in the old Sidebar. Thank you for testing and appreciate the followup!